Skip to content

Linting round6#386

Merged
gregschohn merged 2 commits intoopensearch-project:mainfrom
gregschohn:Linting_Round6
Nov 6, 2023
Merged

Linting round6#386
gregschohn merged 2 commits intoopensearch-project:mainfrom
gregschohn:Linting_Round6

Conversation

@gregschohn
Copy link
Copy Markdown
Collaborator

Description

[Describe what this change achieves]

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
  • Why these changes are required?
  • What is the old behavior before changes and new behavior after changes?

Issues Resolved

[List any issues this PR will resolve]

Is this a backport? If so, please add backport PR # and/or commits #

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

These include significant rethinks on some very-outer layer handling of shutdown signals for the TrafficReplayer.

Signed-off-by: Greg Schohn <greg.schohn@gmail.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 3, 2023

Codecov Report

Merging #386 (4b92aa7) into main (adb465d) will decrease coverage by 0.42%.
Report is 6 commits behind head on main.
The diff coverage is 2.40%.

❗ Current head 4b92aa7 differs from pull request most recent head 96bb0ff. Consider uploading reports for the commit 96bb0ff to get more accurate results

@@             Coverage Diff              @@
##               main     #386      +/-   ##
============================================
- Coverage     63.96%   63.55%   -0.42%     
+ Complexity      718      715       -3     
============================================
  Files            82       82              
  Lines          3283     3298      +15     
  Branches        302      303       +1     
============================================
- Hits           2100     2096       -4     
- Misses          995     1014      +19     
  Partials        188      188              
Flag Coverage Δ
unittests 63.55% <2.40%> (-0.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ch/migrations/replay/SourceTargetCaptureTuple.java 0.00% <0.00%> (ø)
.../opensearch/migrations/replay/TrafficReplayer.java 16.26% <2.50%> (-1.38%) ⬇️

... and 1 file with indirect coverage changes

@gregschohn gregschohn changed the base branch from main to ReusedReplayerClientConnections November 6, 2023 20:42
@gregschohn gregschohn changed the base branch from ReusedReplayerClientConnections to main November 6, 2023 20:43
Comment thread TrafficCapture/sonar-project.properties Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Signed-off-by: Greg Schohn <greg.schohn@gmail.com>
@gregschohn gregschohn merged commit e5ed0eb into opensearch-project:main Nov 6, 2023
@gregschohn gregschohn deleted the Linting_Round6 branch November 7, 2023 03:28
AndreKurait added a commit to AndreKurait/opensearch-migrations that referenced this pull request Apr 15, 2026
…y read (CVE)

Addresses Dependabot alert opensearch-project#386: OTLP HTTP exporters read unbounded HTTP
response bodies, enabling memory exhaustion via a malicious collector endpoint.

Bumps go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp from
1.40.0 to 1.43.0 which includes the fix from open-telemetry/opentelemetry-go#8108.

Also aligns otlptrace and stdoutmetric exporters to v1.43.0 for consistency.

Signed-off-by: Andre Kurait <andrekurait@gmail.com>
AndreKurait added a commit to AndreKurait/opensearch-migrations that referenced this pull request Apr 15, 2026
…y read (CVE)

Addresses Dependabot alert opensearch-project#386: OTLP HTTP exporters read unbounded HTTP
response bodies, enabling memory exhaustion via a malicious collector endpoint.

Bumps go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp from
1.40.0 to 1.43.0 which includes the fix from open-telemetry/opentelemetry-go#8108.

Also aligns otlptrace and stdoutmetric exporters to v1.43.0 for consistency.

Signed-off-by: Andre Kurait <andrekurait@gmail.com>
AndreKurait added a commit to AndreKurait/opensearch-migrations that referenced this pull request Apr 15, 2026
…y read (CVE)

Addresses Dependabot alert opensearch-project#386: OTLP HTTP exporters read unbounded HTTP
response bodies, enabling memory exhaustion via a malicious collector endpoint.

Bumps go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp from
1.40.0 to 1.43.0 which includes the fix from open-telemetry/opentelemetry-go#8108.

Also aligns otlptrace and stdoutmetric exporters to v1.43.0 for consistency.

Signed-off-by: Andre Kurait <andrekurait@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants