Merged
Conversation
…eptions are handled (see SonarQube rule: S2142). Signed-off-by: Greg Schohn <greg.schohn@gmail.com>
Signed-off-by: Greg Schohn <greg.schohn@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #380 +/- ##
============================================
- Coverage 64.23% 63.91% -0.33%
+ Complexity 726 721 -5
============================================
Files 82 82
Lines 3277 3289 +12
Branches 306 306
============================================
- Hits 2105 2102 -3
- Misses 983 997 +14
- Partials 189 190 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gregschohn
requested review from
chelma,
kartg,
lewijacn,
mikaylathompson,
okhasawn and
sumobrian
as code owners
lewijacn
approved these changes
Nov 3, 2023
| new FileOutputStream(params.outputFilename, true); | ||
| var bufferedOutputStream = new BufferedOutputStream(outputStream); | ||
| var blockingTrafficStream = TrafficCaptureSourceFactory.createTrafficCaptureSource(params, | ||
| Duration.ofSeconds(params.lookaheadTimeSeconds)); |
Contributor
There was a problem hiding this comment.
Can we add another line here or something to distinguish that the try parenthesis has now ended
Collaborator
Author
There was a problem hiding this comment.
You & I think alike ;).
I got fed up with too many resources and not knowing where the distinction was & did that in the last delinting PR.
| try { | ||
| pullCaptureFromSourceToAccumulator(trafficChunkStream, trafficToHttpTransactionAccumulator); | ||
| } catch (InterruptedException ex) { | ||
| throw ex; |
Contributor
There was a problem hiding this comment.
Do we need to add a Thread.currentThread().interrupt(); here?
Collaborator
Author
There was a problem hiding this comment.
No. The general rule is if you're suppressing that this was an interruption, you should reset the interrupt state. Since we're propagating (so that we don't obscure it), the final catch-receiver can handle re-interrupting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
More improvements to fix issues caught in running a lint checker.
Testing
./gradlew allTests
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.