test: migrate KNNVectorFieldMapperUtilTests and KNNVectorFieldTypeTests from k-nn#407
Closed
kush992 wants to merge 1 commit intoopensearch-project:mainfrom
Closed
test: migrate KNNVectorFieldMapperUtilTests and KNNVectorFieldTypeTests from k-nn#407kush992 wants to merge 1 commit intoopensearch-project:mainfrom
kush992 wants to merge 1 commit intoopensearch-project:mainfrom
Conversation
…ts from k-nn Signed-off-by: Kush Bhalodi <kush.bhalodi@ibm.com>
kush992
requested review from
akash-shankaran,
jimdickinson,
reta,
sam-herman and
sandoichi
as code owners
Collaborator
|
Thanks @kush992 , could you please run:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Migrated below tests from
opensearch-project/k-nnrepo.KNNVectorFieldMapperUtilTests.java- Removes Array based vector serialization k-NN#2587 (this version was picked up to comply with the implementation ofKNNVectorFieldMapperUtil.javain this repo.KNNVectorFieldTypeTests.java- referenced the current tests inopensearch-project/k-nnto adjust tests in this repoRelated Issues
Resolves #[Issue number to be closed when this PR is merged]
#393
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.