[Backport] [3.x] Update Specification and Re-generate Code (#1890) - #1894
Merged
Merged
Conversation
reta
requested review from
Bukhtawar,
VachaShah,
Xtansia,
madhusudhankonda,
saratvemulapalli and
szczepanczykd
as code owners
February 22, 2026 21:56
Signed-off-by: Andriy Redko <drreta@gmail.com> (cherry picked from commit 779e31a) Signed-off-by: Andriy Redko <drreta@gmail.com>
reta
force-pushed
the
backport/backport-1890-to-3.x
branch
from
February 22, 2026 22:24
e772791 to
22784c0
Compare
Xtansia
reviewed
Feb 22, 2026
|
|
||
| @Nonnull | ||
| private final List<ShardFailure> failures; | ||
| private final List<ShardSearchFailure> failures; |
Collaborator
There was a problem hiding this comment.
This is technically a breaking change for 3.x
Collaborator
Author
There was a problem hiding this comment.
Thanks @Xtansia . Yes, it is, sadly, we have discussed it over here #1877 (comment), I honestly unsure what would be the best option here:
- revert ShardFailure changes for
primaryetc - or adsorb this breaking change (since ShardSearchFailure will never have
primarypopulated, it is never returned by the server)
Xtansia
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #1890 to 3.x