Conversation
#739) * [Vis Augmenter / Feature Anywhere] Add test suite for vanilla OSD + helper fns for plugins (#725) * feature anywhere initial tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Add test suite Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Remove unnecessary test case Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Optimize getters Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [Feature Anywhere / Vis Augmenter] Add test flows for integration with AD plugin (#727) * feature anywhere initial tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Add test suite Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Add AD vis augmenter tests Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * More refactoring Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * More tests Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Add test for AD cleanup scenario Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Set up saved obj test suite Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Add reminder TODO Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Add tests regarding saved obj visibility Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Add view events tests Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * cleanup Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * remove import Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> (cherry picked from commit 07a67d7)
opensearch-trigger-bot
Bot
requested review from
Hailong-am,
SuZhou-Joe,
raintygao,
ruanyl,
wanglam and
xluo-aws
as code owners
kavilla
approved these changes
Jul 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 07a67d7 from #739