Skip to content

Use library from release tag instead of git reference #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ananzh merged 1 commit into from
Jul 10, 2023
Merged

Use library from release tag instead of git reference #706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"homepage": "https://github.com/opensearch-project/opensearch-dashboards-functional-test",
"dependencies": {
"@cypress/skip-test": "^2.6.1",
"@opensearch-dashboards-test/opensearch-dashboards-test-library": "git+https://github.com/opensearch-project/opensearch-dashboards-test-library.git#main",
"@opensearch-dashboards-test/opensearch-dashboards-test-library": "https://github.com/opensearch-project/opensearch-dashboards-test-library/archive/refs/tags/1.0.4.tar.gz",
Copy link
Copy Markdown
Collaborator

@CCongWang CCongWang Jun 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to update the link everytime we make change in test library?

Copy link
Copy Markdown
Member Author

@kavilla kavilla Jun 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we have changes in the library which is stable more or less.

This is versus clearing NPM cache which was causing differences in environments. The previous way was only beneficial for environments first-time installation. As my local would still install an older version and modify my lock file and then my tests will fail.

"brace": "^0.11.1",
"prettier": "^2.5.1"
},
Expand Down