-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update vanilla snapshot test to match with package.json and replace deprecated set-output #676
Update vanilla snapshot test to match with package.json and replace deprecated set-output #676
Conversation
Signed-off-by: Peter Zhu <[email protected]>
Also removed two disabled workflows that have not being used for a long time. |
Need to work with @RyanL1997 to fix the data table then have the version dynamically change based on |
@peterzhuamazon (cc @ananzh ) Here are some of the findings about the failure of It seems like we are missing this |
Signed-off-by: Peter Zhu <[email protected]>
Thanks @RyanL1997 for looking this up. Thanks. |
Signed-off-by: Peter Zhu <[email protected]>
Table fix incoming |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-676-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2fa1ad4134498468858a90480ad704354ea2a51a
# Push it to GitHub
git push --set-upstream origin backport/backport-676-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.3 1.3
# Navigate to the new working tree
cd .worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-676-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2fa1ad4134498468858a90480ad704354ea2a51a
# Push it to GitHub
git push --set-upstream origin backport/backport-676-to-1.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.3 Then, create a pull request where the |
…ut (#676) * Update vanilla snapshot test and replace deprecated set-output Signed-off-by: Peter Zhu <[email protected]> * Make workflow checkout version based on package.json Signed-off-by: Peter Zhu <[email protected]> * Make workflow checkout version based on package.json Signed-off-by: Peter Zhu <[email protected]> --------- Signed-off-by: Peter Zhu <[email protected]> (cherry picked from commit 2fa1ad4)
Signed-off-by: Peter Zhu <[email protected]>
…ut (#676) (#685) * Update vanilla snapshot test and replace deprecated set-output Signed-off-by: Peter Zhu <[email protected]> * Make workflow checkout version based on package.json Signed-off-by: Peter Zhu <[email protected]> * Make workflow checkout version based on package.json Signed-off-by: Peter Zhu <[email protected]> --------- Signed-off-by: Peter Zhu <[email protected]> (cherry picked from commit 2fa1ad4) Co-authored-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
…ut (opensearch-project#676) (opensearch-project#685) * Update vanilla snapshot test and replace deprecated set-output Signed-off-by: Peter Zhu <[email protected]> * Make workflow checkout version based on package.json Signed-off-by: Peter Zhu <[email protected]> * Make workflow checkout version based on package.json Signed-off-by: Peter Zhu <[email protected]> --------- Signed-off-by: Peter Zhu <[email protected]> (cherry picked from commit 2fa1ad4) Co-authored-by: Peter Zhu <[email protected]> Signed-off-by: [email protected] <[email protected]>
Description
Update vanilla snapshot test to match with package.json and replace deprecated set-output
Issues Resolved
opensearch-project/opensearch-build#3434
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.