Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vanilla snapshot test to match with package.json and replace deprecated set-output #676

Merged

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented May 25, 2023

Description

Update vanilla snapshot test to match with package.json and replace deprecated set-output

Issues Resolved

opensearch-project/opensearch-build#3434

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peterzhuamazon
Copy link
Member Author

Also removed two disabled workflows that have not being used for a long time.

@peterzhuamazon peterzhuamazon changed the title Update vanilla snapshot test and replace deprecated set-output Update vanilla snapshot test to 2.7.0 and replace deprecated set-output May 25, 2023
@peterzhuamazon
Copy link
Member Author

Need to work with @RyanL1997 to fix the data table then have the version dynamically change based on version in package.json.

@RyanL1997
Copy link
Contributor

RyanL1997 commented May 25, 2023

@peterzhuamazon (cc @ananzh )

Here are some of the findings about the failure of data tables test case:
OS version 2.7 with Cypress 9
issuesOn2 7Cy9

OS version 2.0 with Cypress 9
issuesOn2 0Cy9

It seems like we are missing this paginated-table-body for the latest OS version.

@peterzhuamazon
Copy link
Member Author

peterzhuamazon commented May 25, 2023

@peterzhuamazon (cc @ananzh )

Here are some of the findings about the failure of data tables test case: OS version 2.7 with Cypress 9
It seems like we are missing this paginated-table-body for the latest OS version.

Thanks @RyanL1997 for looking this up.
Meanwhile, I have pushed a change to auto grab the version defined in package.json.
So that this test can properly install the corresponding versions instead of hardcoding to 2.0.0 or others.

Thanks.

@kavilla
Copy link
Member

kavilla commented May 26, 2023

Table fix incoming

@kavilla kavilla merged commit 2fa1ad4 into opensearch-project:main May 26, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-676-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2fa1ad4134498468858a90480ad704354ea2a51a
# Push it to GitHub
git push --set-upstream origin backport/backport-676-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-676-to-1.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.3 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.3 1.3
# Navigate to the new working tree
cd .worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-676-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2fa1ad4134498468858a90480ad704354ea2a51a
# Push it to GitHub
git push --set-upstream origin backport/backport-676-to-1.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.3

Then, create a pull request where the base branch is 1.3 and the compare/head branch is backport/backport-676-to-1.3.

opensearch-trigger-bot bot pushed a commit that referenced this pull request May 26, 2023
…ut (#676)

* Update vanilla snapshot test and replace deprecated set-output

Signed-off-by: Peter Zhu <[email protected]>

* Make workflow checkout version based on package.json

Signed-off-by: Peter Zhu <[email protected]>

* Make workflow checkout version based on package.json

Signed-off-by: Peter Zhu <[email protected]>

---------

Signed-off-by: Peter Zhu <[email protected]>
(cherry picked from commit 2fa1ad4)
peterzhuamazon added a commit to peterzhuamazon/opensearch-dashboards-functional-test that referenced this pull request May 26, 2023
@peterzhuamazon peterzhuamazon deleted the update_github_actions_2.8.0 branch May 26, 2023 16:57
peterzhuamazon added a commit that referenced this pull request May 26, 2023
…ut (#676) (#685)

* Update vanilla snapshot test and replace deprecated set-output

Signed-off-by: Peter Zhu <[email protected]>

* Make workflow checkout version based on package.json

Signed-off-by: Peter Zhu <[email protected]>

* Make workflow checkout version based on package.json

Signed-off-by: Peter Zhu <[email protected]>

---------

Signed-off-by: Peter Zhu <[email protected]>
(cherry picked from commit 2fa1ad4)

Co-authored-by: Peter Zhu <[email protected]>
@peterzhuamazon peterzhuamazon changed the title Update vanilla snapshot test to 2.7.0 and replace deprecated set-output Update vanilla snapshot test to match with package.json and replace deprecated set-output May 26, 2023
CCongWang pushed a commit that referenced this pull request May 26, 2023
leanneeliatra pushed a commit to leanneeliatra/opensearch-dashboards-functional-test-fork that referenced this pull request Sep 15, 2023
…ut (opensearch-project#676) (opensearch-project#685)

* Update vanilla snapshot test and replace deprecated set-output

Signed-off-by: Peter Zhu <[email protected]>

* Make workflow checkout version based on package.json

Signed-off-by: Peter Zhu <[email protected]>

* Make workflow checkout version based on package.json

Signed-off-by: Peter Zhu <[email protected]>

---------

Signed-off-by: Peter Zhu <[email protected]>
(cherry picked from commit 2fa1ad4)

Co-authored-by: Peter Zhu <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

4 participants