Add test cases for filter of aggregation view feature#357
Conversation
Signed-off-by: Ryan Liang <jiallian@amazon.com>
|
A side note: there is an existing folder The workflow is running against |
Hi @tianleh, thanks for the information. Yes, we intentionally keep our test in a separate folder for following reasons:
|
|
Please mark "Ready for review" when it is ready for review. Since it is not included in the e2e workflow, could you attach the Cypress video when running from your local? |
|
Also please add backport labels if this requires backport. |
|
Hi @tianleh, I just uploaded the cypress test recording and this PR is ready for review. Could you please also help me to add the backport labels for both 2.x and 2.4 branch? |
| cy.contains('a', 's*'); | ||
| cy.contains('a', 'se*').should('not.exist'); | ||
|
|
||
| cy.wait(3000); |
There was a problem hiding this comment.
We shall have a follow up issue to optimize the wait https://docs.cypress.io/guides/references/best-practices#Unnecessary-Waiting
There was a problem hiding this comment.
Got it, I will create a follow up for optimize those cy.wait(). Thanks for the reminder!
added. |
Signed-off-by: Ryan Liang <jiallian@amazon.com> Signed-off-by: Ryan Liang <jiallian@amazon.com> (cherry picked from commit 37134e9)
Signed-off-by: Ryan Liang <jiallian@amazon.com> Signed-off-by: Ryan Liang <jiallian@amazon.com> (cherry picked from commit 37134e9)
Signed-off-by: Ryan Liang <jiallian@amazon.com> Signed-off-by: Ryan Liang <jiallian@amazon.com> (cherry picked from commit 37134e9) Co-authored-by: Ryan Liang <109499885+RyanL1997@users.noreply.github.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com> Signed-off-by: Ryan Liang <jiallian@amazon.com> (cherry picked from commit 37134e9) Co-authored-by: Ryan Liang <109499885+RyanL1997@users.noreply.github.com>
…ject#357) Signed-off-by: Ryan Liang <jiallian@amazon.com> Signed-off-by: Ryan Liang <jiallian@amazon.com> Signed-off-by: Jakub Przybylski <jakub.przybylski@eliatra.com>
…ject#357) (opensearch-project#363) Signed-off-by: Ryan Liang <jiallian@amazon.com> Signed-off-by: Ryan Liang <jiallian@amazon.com> (cherry picked from commit 37134e9) Co-authored-by: Ryan Liang <109499885+RyanL1997@users.noreply.github.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com>
Signed-off-by: Ryan Liang jiallian@amazon.com
Description
Add test case for filter of aggregation view feature
Issues Resolved
Test Recording
aggregation_view.js.mp4
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.