Add test for aggregation view feature

[RyanL1997]

Signed-off-by: Ryan Liang jiallian@amazon.com

Description

Add test for security dashboard plugin aggregation view feature

• Modify current visit() command to support non-admin authentication and tenant switching when security feature is enabled.
• Extend current createIndexPattern() command to support index pattern creation with tenant header when security feature is enabled

Issues Resolved

• Resolved: Saved Object Aggregation View security-dashboards-plugin#1146

Check List

• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[CCongWang]

looks like many tests share the same code like creating user/role/etc, to make the code clean and reusable, one thing you could do is to create custom commands, like createUser() and createRole(), please check out index management plugin commands as example

[CCongWang]

do you need to backport the tests to other branches like 2.x?

[RyanL1997]

do you need to backport the tests to other branches like 2.x?

Hi @CCongWang , thank you for asking. Yes, I believe we need to backport to 2.x.

[RyanL1997]

looks like many tests share the same code like creating user/role/etc, to make the code clean and reusable, one thing you could do is to create custom commands, like createUser() and createRole(), please check out index management plugin commands as example

Hi @CCongWang, thank you for the review! I just restructured the entire test with your suggestion of adding API call commands, such as, createUser() and createTenant(). By doing this, I believe it will also resolve all the rest comments. Feel free to review the latest commit and let me know if you have further questions.

[ashwin-pc]

Hey Ryan, just have some comments to reduce some redundancy.

[tianleh]

Hi @CCongWang , thank you for asking. Yes, I believe we need to backport to 2.x.

Please add a label called "backport 2.x" to this PR so that our backport workflow can automatically generate a new PR to backport once the current PR is merged.

[tianleh]

Any reason why we need AGGREGATION_VIEW flag around the tests? Is this feature disabled by default?

[RyanL1997]

Any reason why we need AGGREGATION_VIEW flag around the tests? Is this feature disabled by default?

Hi @tianleh, thanks for the review! Yes, the feature is disabled by default, so that the UI behaviors will be different. The test will only run when both of SECURITY_ENABLED and AGGREGATION_VIEW flags are true.

[RyanL1997]

Hi @CCongWang , thank you for asking. Yes, I believe we need to backport to 2.x.

Please add a label called "backport 2.x" to this PR so that our backport workflow can automatically generate a new PR to backport once the current PR is merged.

Done. Thanks for the instruction.

[tianleh]

Done. Thanks for the instruction.

I just added the label. (Label is different from PR title)

[tianleh]

Hi @tianleh, thanks for the review! Yes, the feature is disabled by default, so that the UI behaviors will be different. The test will only run when both of SECURITY_ENABLED and AGGREGATION_VIEW flags are true.

In this case, do you have plan to enable the feature when Github workflow runs https://github.com/opensearch-project/opensearch-dashboards-functional-test/blob/main/.github/workflows/security-release-e2e-workflow.yml ?

We have another feature which is disabled by default. https://github.com/opensearch-project/opensearch-dashboards-functional-test/pull/325/files The PR updates the Github workflow to start OSD with that feature enabled. I am not sure whether your feature can be enabled as simple as that or has to modify the OSD yml file.

The current run https://github.com/opensearch-project/opensearch-dashboards-functional-test/actions/runs/3286221746/jobs/5414100963 doesn't run your tests. Let me know your plan.

[cliu123]

@tianleh We don't have plan to enable the feature when the release e2e workflow runs. The feature gets enabled by setting a feature flag to true in opensearch_dashboards.yml file.
These tests run as a part of security-dashboards-plugin CI workflow: https://github.com/opensearch-project/security-dashboards-plugin/actions/runs/3285025563

[RyanL1997]

Thanks for all the reviews! I have resolved all the comments, and this PR is ready to be merged now.