Skip to content

include security-dashboards-plugin into security CI#1140

Merged
Hailong-am merged 1 commit into
opensearch-project:mainfrom
Hailong-am:main
Mar 20, 2024
Merged

include security-dashboards-plugin into security CI#1140
Hailong-am merged 1 commit into
opensearch-project:mainfrom
Hailong-am:main

Conversation

@Hailong-am
Copy link
Copy Markdown
Collaborator

Description

#1139

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Hailong Cui <ihailong@amazon.com>
Copy link
Copy Markdown
Member

@ruanyl ruanyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, do you know why the test wasn't run before?

@Hailong-am
Copy link
Copy Markdown
Collaborator Author

do you know why the test wasn't run before?

At the first time, there only have security folder so the filter looks right. When this pr #609 introduce a new folder security-dashboard-plugin, it doesn't include in the filters.

@Hailong-am Hailong-am merged commit 6e3cc01 into opensearch-project:main Mar 20, 2024
opensearch-trigger-bot Bot pushed a commit that referenced this pull request Mar 20, 2024
Signed-off-by: Hailong Cui <ihailong@amazon.com>
(cherry picked from commit 6e3cc01)
Hailong-am added a commit that referenced this pull request Mar 20, 2024
Signed-off-by: Hailong Cui <ihailong@amazon.com>
(cherry picked from commit 6e3cc01)

Co-authored-by: Hailong Cui <ihailong@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Github action not run for security-dashboard-plugin

4 participants