Toggle -Pcrypto.standard=FIPS-140-3 by default on all build scripts (Build)

[peterzhuamazon]

Description

Toggle -Pcrypto.standard=FIPS-140-3 by default on all build scripts (Build)

Issues Resolved

#5979

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

📝 Walkthrough

Walkthrough

Build scripts across multiple OpenSearch components are updated to include the Gradle property -Pcrypto.standard=FIPS-140-3 in their build and publication tasks. The changes are consistent across all affected scripts with no modifications to control flow or error handling.

Changes

Cohort / File(s)	Summary
Core OpenSearch components scripts/components/OpenSearch-DataFusion/build.sh, scripts/components/OpenSearch/build.sh	Added -Pcrypto.standard=FIPS-140-3 Gradle property to publishToMavenLocal, publishNebulaPublicationToTestRepository, distribution assemble, and core plugins assemble tasks.
Notification components scripts/components/notifications-core/build.sh, scripts/components/notifications/build.sh	Added -Pcrypto.standard=FIPS-140-3 Gradle property to assemble, publishToMavenLocal, and publishPluginZipPublicationToZipStagingRepository tasks.
Default OpenSearch scripts/default/opensearch/build.sh	Added -Pcrypto.standard=FIPS-140-3 Gradle property to assemble and plugin-publication tasks.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check	✅ Passed	The title accurately summarizes the main change: enabling FIPS-140-3 crypto standard across all build scripts.
Description check	✅ Passed	The description clearly relates to the changeset, referencing the specific issue being resolved and the Apache 2.0 license compliance.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.58%. Comparing base (2f8f564) to head (c20f50b).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5995   +/-   ##
=======================================
  Coverage   96.58%   96.58%           
=======================================
  Files         405      405           
  Lines       18723    18723           
=======================================
  Hits        18084    18084           
  Misses        639      639           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[gaiksaya]

@peterzhuamazon Same scripts will be used for 2.19.x patch releases as well. And I am assuming this only applies to >=3.6 version.

[peterzhuamazon]

Hi @gaiksaya

1. This is ok as that param will not take any effect in 2.x as the code is not commited in 2.x so it is just a no-op. Confirmed with @cwperks.
2. Removed empty file.

Thanks!

[gaiksaya]

1. This is ok as that param will not take any effect in 2.x as the code is not commited in 2.x so it is just a no-op. Confirmed with @cwperks.

Since it is just a gradle property should not cause any issue. Please keep watch in case anyone backports to 2.19 by mistake.

[peterzhuamazon]

1. This is ok as that param will not take any effect in 2.x as the code is not commited in 2.x so it is just a no-op. Confirmed with @cwperks.

Since it is just a gradle property should not cause any issue. Please keep watch in case anyone backports to 2.19 by mistake.

It should be fine as the core code was merged back in 3.1.