Allow 1.x deb/rpm to use the old build templates #4536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Zhu <[email protected]>
peterzhuamazon
added
enhancement
peterzhuamazon
requested review from
dblock,
bbarani,
gaiksaya,
rishabh6788,
zelinh,
jordarlu,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
This was referenced Mar 15, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4536 +/- ##
=======================================
Coverage 92.16% 92.16%
=======================================
Files 192 192
Lines 6282 6282
=======================================
Hits 5790 5790
Misses 492 492 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
jordarlu
approved these changes
Mar 15, 2024
Divyaasm
pushed a commit
to Divyaasm/opensearch-build
that referenced
this pull request
Mar 21, 2024
…4536) Signed-off-by: Peter Zhu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow 1.x deb/rpm to use the old build templates.
Move existing changes @ #4043 (88dfb7f) to
current, and old changes @ #4163 (35048a4) tolegacy.So that 1.x will use the templates without
admin:adminchanges, while 2.x or above can consume the new ones includingadmin:adminandpermissions tightenchanges.Issues Resolved
#3815
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.