Skip to content

Adding SQL to 2.4 manifest#2684

Closed
penghuo wants to merge 1 commit intoopensearch-project:mainfrom
penghuo:2.4
Closed

Adding SQL to 2.4 manifest#2684
penghuo wants to merge 1 commit intoopensearch-project:mainfrom
penghuo:2.4

Conversation

@penghuo
Copy link
Copy Markdown
Contributor

@penghuo penghuo commented Oct 3, 2022

Signed-off-by: Peng Huo penghuo@gmail.com

Description

Related to opensearch-project/sql#831. Required 2.4.0.0 for bwc test.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peng Huo <penghuo@gmail.com>
@penghuo penghuo requested a review from a team as a code owner October 3, 2022 16:54
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 3, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.10%. Comparing base (55b2622) to head (28df0c7).
⚠️ Report is 2163 commits behind head on main.

❌ Your project status has failed because the head coverage (94.10%) is below the target coverage (98.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2684   +/-   ##
=======================================
  Coverage   94.10%   94.10%           
=======================================
  Files         156      156           
  Lines        4208     4208           
=======================================
  Hits         3960     3960           
  Misses        248      248           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@peterzhuamazon
Copy link
Copy Markdown
Member

Close this for now as I will add it to the #2678 soon.

cc: @penghuo

Thanks.

@Yury-Fridlyand
Copy link
Copy Markdown

@peterzhuamazon,
The proposed changes are missing in the PR you mentioned. Are you planning to add them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants