Fix zip distribution does not include leading directory#2672
Merged
peterzhuamazon merged 2 commits intoopensearch-project:mainfrom Sep 29, 2022
Merged
Conversation
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Member
Author
|
In every other distribution when you extract the artifact, the leading subdirectory will be in the pattern of |
1 task
dblock
approved these changes
Sep 29, 2022
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
prudhvigodithi
approved these changes
Sep 29, 2022
Member
Author
|
The groovy test is failing due to an unrelated issue, merge here. |
Member
Author
peterzhuamazon
added a commit
to peterzhuamazon/opensearch-build
that referenced
this pull request
Sep 30, 2022
…roject#2672) * Fix zip distribution does not include leading directory Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Resolve the path issues failed on Windows Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
peterzhuamazon
added a commit
that referenced
this pull request
Oct 5, 2022
* Test windows Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Test windows Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Test snapshots Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add new manifests Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Test again Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Fix zip distribution does not include leading directory (#2672) * Fix zip distribution does not include leading directory Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Resolve the path issues failed on Windows Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Tweak 1.3.6 Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add some plugins to the 1.3.6 manifest (#2670) * Add security plugin into the manifest Signed-off-by: Zelin Hao <zelinhao@amazon.com> * Add more components Signed-off-by: Zelin Hao <zelinhao@amazon.com> Signed-off-by: Zelin Hao <zelinhao@amazon.com> * Add more Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add more Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add more Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add more Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add more Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Change when condition Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * change params Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add verify params Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add verify params Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Remove .swp Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add more comment Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Fix issues Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * More changes Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Zelin Hao <zelinhao@amazon.com> Co-authored-by: Zelin Hao <87548827+zelinh@users.noreply.github.com>
monusingh-1
pushed a commit
to monusingh-1/os_build
that referenced
this pull request
Nov 2, 2022
…roject#2672) * Fix zip distribution does not include leading directory Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Resolve the path issues failed on Windows Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Monu Singh <msnghgw@amazon.com>
monusingh-1
pushed a commit
to monusingh-1/os_build
that referenced
this pull request
Nov 2, 2022
…ch-project#2678) * Test windows Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Test windows Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Test snapshots Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add new manifests Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Test again Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Fix zip distribution does not include leading directory (opensearch-project#2672) * Fix zip distribution does not include leading directory Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Resolve the path issues failed on Windows Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Tweak 1.3.6 Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add some plugins to the 1.3.6 manifest (opensearch-project#2670) * Add security plugin into the manifest Signed-off-by: Zelin Hao <zelinhao@amazon.com> * Add more components Signed-off-by: Zelin Hao <zelinhao@amazon.com> Signed-off-by: Zelin Hao <zelinhao@amazon.com> * Add more Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add more Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add more Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add more Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add more Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Change when condition Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * change params Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add verify params Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add verify params Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Remove .swp Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add more comment Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Fix issues Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * More changes Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Zelin Hao <zelinhao@amazon.com> Co-authored-by: Zelin Hao <87548827+zelinh@users.noreply.github.com> Signed-off-by: Monu Singh <msnghgw@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Peter Zhu zhujiaxi@amazon.com
Description
Fix zip distribution does not include leading directory
Issues Resolved
#2306
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.