Add Common Utils to 2.2 manifest#2363
Merged
prudhvigodithi merged 1 commit intoopensearch-project:mainfrom Jul 26, 2022
Merged
Conversation
Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (94.61%) is below the target coverage (98.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #2363 +/- ##
=========================================
Coverage 94.61% 94.61%
Complexity 27 27
=========================================
Files 209 209
Lines 4309 4309
Branches 29 29
=========================================
Hits 4077 4077
Misses 226 226
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
The failed GitHub Action seems to be for a version unrelated to this PR. @peterzhuamazon Would you be able to review and take a look? |
zelinh
approved these changes
Jul 25, 2022
Member
zelinh
left a comment
zelinh
left a comment
There was a problem hiding this comment.
CI failed due to a known issue. Approved this to unblock for 2.2 release.
prudhvigodithi
approved these changes
Jul 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mohammad Qureshi 47198598+qreshi@users.noreply.github.com
Description
Adding common-utils to 2.2 manifest as a follow-up to opensearch-project/common-utils#204
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.