Skip to content

Removing Build Scripts for Notifications Plugin#1938

Closed
adityaj1107 wants to merge 1 commit intoopensearch-project:mainfrom
adityaj1107:remove-notification-build-scripts
Closed

Removing Build Scripts for Notifications Plugin#1938
adityaj1107 wants to merge 1 commit intoopensearch-project:mainfrom
adityaj1107:remove-notification-build-scripts

Conversation

@adityaj1107
Copy link
Copy Markdown
Contributor

Description

This PR removes the build scripts for the Notifications and the Notifications Dashboard since we have a PR to add them directly to the notifications project (opensearch-project/notifications#398). We are removing them since these take precedence.

Issues Resolved

#1933

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Aditya Jindal <aditjind@amazon.com>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 7, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.60%. Comparing base (5e82386) to head (5bf1549).
⚠️ Report is 2598 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1938   +/-   ##
=========================================
  Coverage     94.60%   94.60%           
  Complexity       20       20           
=========================================
  Files           178      178           
  Lines          3633     3633           
  Branches         27       27           
=========================================
  Hits           3437     3437           
  Misses          192      192           
  Partials          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

gaiksaya
gaiksaya previously approved these changes Apr 7, 2022
@gaiksaya gaiksaya dismissed their stale review April 7, 2022 20:47

Waiting for other PR to get merged first

@peterzhuamazon
Copy link
Copy Markdown
Member

We will close this PR because due to BE notifications have 2 level2 subfolders within level1 subfolder, the scripts will current sit in build repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants