Removing Build Scripts for Notifications Plugin#1938
Closed
adityaj1107 wants to merge 1 commit intoopensearch-project:mainfrom
adityaj1107:remove-notification-build-scripts
Closed
Removing Build Scripts for Notifications Plugin#1938adityaj1107 wants to merge 1 commit intoopensearch-project:mainfrom adityaj1107:remove-notification-build-scripts
adityaj1107 wants to merge 1 commit intoopensearch-project:mainfrom
adityaj1107:remove-notification-build-scripts
Conversation
Signed-off-by: Aditya Jindal <aditjind@amazon.com>
6 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1938 +/- ##
=========================================
Coverage 94.60% 94.60%
Complexity 20 20
=========================================
Files 178 178
Lines 3633 3633
Branches 27 27
=========================================
Hits 3437 3437
Misses 192 192
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
qreshi
approved these changes
Apr 7, 2022
gaiksaya
previously approved these changes
Apr 7, 2022
6 tasks
Member
|
We will close this PR because due to BE notifications have 2 level2 subfolders within level1 subfolder, the scripts will current sit in build repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the build scripts for the Notifications and the Notifications Dashboard since we have a PR to add them directly to the notifications project (opensearch-project/notifications#398). We are removing them since these take precedence.
Issues Resolved
#1933
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.