Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSD][1.3.1][Integ] add ftr repo #1890

Merged
merged 2 commits into from
Apr 1, 2022

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Apr 1, 2022

Description

Add the functional test repo to the build

Signed-off-by: Kawika Avilla [email protected]

Issues Partially resolved

#1885

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Kawika Avilla <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2022

Codecov Report

Merging #1890 (cc1ade8) into main (96ce20a) will decrease coverage by 0.13%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1890      +/-   ##
============================================
- Coverage     94.54%   94.40%   -0.14%     
  Complexity       19       19              
============================================
  Files           178      178              
  Lines          3630     3630              
  Branches         27       27              
============================================
- Hits           3432     3427       -5     
- Misses          194      199       +5     
  Partials          4        4              
Impacted Files Coverage Δ
src/system/temporary_directory.py 83.87% <0.00%> (-12.91%) ⬇️
src/system/os.py 93.75% <0.00%> (-6.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96ce20a...cc1ade8. Read the comment docs.

@kavilla kavilla changed the title [OSD][Integ] add ftr repo [OSD][1.3.1][Integ] add ftr repo Apr 1, 2022
@@ -10,3 +10,6 @@ components:
- name: OpenSearch-Dashboards
repository: https://github.com/opensearch-project/OpenSearch-Dashboards.git
ref: '1.3'
- name: functionalTestDashboards
repository: https://github.com/opensearch-project/opensearch-dashboards-functional-test.git
ref: tags/1.3.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we 1.3 branch or main? I remember once 1.3.1 is officially release, we will create tag 1.3.1 and then update here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you plan on doing a version bump ? For this repo it doesn't get bundled so I thought I'd use the tags/1.3.0, I can make this 1.3

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm I think someone backported a improvement for flakiness. Let's use the branch. updated.

Signed-off-by: Kawika Avilla <[email protected]>
@kavilla kavilla requested a review from tianleh April 1, 2022 23:24
@kavilla kavilla merged commit 210de0b into opensearch-project:main Apr 1, 2022
@kavilla kavilla deleted the avillk/1.3.1/buildftr branch April 1, 2022 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants