-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OSD][1.3.1][Integ] add ftr repo #1890
[OSD][1.3.1][Integ] add ftr repo #1890
Conversation
Signed-off-by: Kawika Avilla <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1890 +/- ##
============================================
- Coverage 94.54% 94.40% -0.14%
Complexity 19 19
============================================
Files 178 178
Lines 3630 3630
Branches 27 27
============================================
- Hits 3432 3427 -5
- Misses 194 199 +5
Partials 4 4
Continue to review full report at Codecov.
|
@@ -10,3 +10,6 @@ components: | |||
- name: OpenSearch-Dashboards | |||
repository: https://github.com/opensearch-project/OpenSearch-Dashboards.git | |||
ref: '1.3' | |||
- name: functionalTestDashboards | |||
repository: https://github.com/opensearch-project/opensearch-dashboards-functional-test.git | |||
ref: tags/1.3.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shall we 1.3 branch or main? I remember once 1.3.1 is officially release, we will create tag 1.3.1 and then update here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you plan on doing a version bump ? For this repo it doesn't get bundled so I thought I'd use the tags/1.3.0
, I can make this 1.3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nvm I think someone backported a improvement for flakiness. Let's use the branch. updated.
Signed-off-by: Kawika Avilla <[email protected]>
Description
Add the functional test repo to the build
Signed-off-by: Kawika Avilla [email protected]
Issues Partially resolved
#1885
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.