-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build test Darwin version of min OpenSearch distribution to support plugin testing on MacOS. #2216
Comments
Hi @prudhvigodithi and @bbarani, how much effort will this take to do/what release will this be targeted for? Do we already have support for MacOS ec2 agent's? Are there any tasks on this I could pick up? |
Hey we have development version of Darwin 2.1.1 Mac -min artifact can be downloaded from Please test and provide your feedback. Thanks! |
Thanks @prudhvigodithi! When running:
However, when downloading custom url and using it, it appears to work (will confirm in about 20 min - accidentally posted comment too soon):
|
Confirmed build was successful! Is it possible to publish artifact to "https://artifacts.opensearch.org" instead of "https://ci.opensearch.org" so that we dont have to pass -PcustomDistributionUrl flag for building? For opensearchplugin, ARCHIVE defaults to "https://artifacts.opensearch.org" |
Signed-off-by: prudhvigodithi <[email protected]>
Hey We now have the darwin min snapshot artifacts accessible via https://artifacts.opensearch.org/, the default URL used in OpenSearch. Jenkins build Mac 2.2.0-SNAPSHOT https://artifacts.opensearch.org/snapshots/core/opensearch/2.2.0-SNAPSHOT/opensearch-min-2.2.0-SNAPSHOT-darwin-x64-latest.tar.gz Jenkins build Mac 2.1.1-SNAPSHOT https://artifacts.opensearch.org/snapshots/core/opensearch/2.1.1-SNAPSHOT/opensearch-min-2.1.1-SNAPSHOT-darwin-x64-latest.tar.gz @jmazanec15 when you get a chance can you please test and update? |
Thanks @prudhvigodithi, this is amazing . I happen to work with AD plugin and it works!!
|
Thanks for testing @saratvemulapalli ;) |
Closing this issue as the tasks part of this META issue are marked complete, please feel free to re-open if required. |
Hi @prudhvigodithi while trying to build async-search for 3.0.0 in mac I'm facing the below error:
Is there a way to check the url is correct or not? I'm not able to visit the base ci.opensearch.org as well since it says forbidden on browser. |
Hey @Arpit-Bandejiya the URL is as follows
Please try with this and let me know. |
This works @prudhvigodithi thanks! |
@prudhvigodithi I have one question though when I build it without passing this flag, I get this error:
As can be seen the url is same as one we passed in command line. Any possible reason of this failing? |
Hey @Arpit-Bandejiya We are publishing darwin Sample Download URL: Mac os support Useful blog's: So in your case please use |
Is your feature request related to a problem? Please describe
For k-NN, to run integ tests on Mac is not compatible.
KNN uses lang painless to inject scripts. To test on MacOS right now the options are
INTEG_TEST
, which will bring up a cluster with plain and no modules (mainly lang painless) except transportModulesFilesSecond option is to use
ARCHIVE
which will allow direct download of zip and test bringing up the cluster, which looks for darwin zip, which is not available for testing.opensearch-project/OpenSearch#1676
Describe the solution you'd like
darwin
.Test the existing build_workflow to run the OpenSearch build with platform as darwin. #2350
Add a new darwin build stage to OpenSearch distribution pipeline #2361
Formalize the MacOS agent's AMI creation using packer. opensearch-ci#163
Add agent configuration support Mac jenkins agents opensearch-ci#157
[Bug]: Missing required packages on macOS agents. #2375
/bin/bash
, removenodeProperties
in CDK code and allow jenkins to use defaultPATH
part ofAMI
.MacOS agents support default
/bin/bash
and removenodeProperties
in CDK code. opensearch-ci#174Jenkins build Mac 2.2.0-SNAPSHOT
Describe alternatives you've considered
Other alternatives is to test on Linux, Docker but this requires developers with MacOs to setup alternative virtual machines to test the plugins.
Additional context
#38 (comment)
Acceptance Criteria
distribution:archives:darwin-arm64-tar:assemble
to build the darwin min distribution, integrate with build workflow to automate the min distribution creation.MACHTYPE=x86_64
The text was updated successfully, but these errors were encountered: