-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tests for /_validate/query. #739
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
requested review from
harshavamsi,
sachetalva,
nhtruong,
Xtansia,
VachaShah,
Tokesh and
aabeshov
as code owners
December 16, 2024 22:36
Changes AnalysisCommit SHA: a53c487 API ChangesSummaryNO CHANGES ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/12374890324/artifacts/2332259069 API Coverage
|
Signed-off-by: dblock <[email protected]>
Signed-off-by: dblock <[email protected]>
dblock
force-pushed
the
validate-query
branch
from
December 17, 2024 14:17
b1f4696
to
a53c487
Compare
Spec Test Coverage Analysis
|
Tokesh
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, LGTM!
nathaliellenaa
pushed a commit
to nathaliellenaa/opensearch-api-specification
that referenced
this pull request
Dec 17, 2024
* Added tests for /_validate/query. Signed-off-by: dblock <[email protected]> * Added retry for opensearch-project#738. Signed-off-by: dblock <[email protected]> --------- Signed-off-by: dblock <[email protected]>
nathaliellenaa
pushed a commit
to nathaliellenaa/opensearch-api-specification
that referenced
this pull request
Dec 18, 2024
* Added tests for /_validate/query. Signed-off-by: dblock <[email protected]> * Added retry for opensearch-project#738. Signed-off-by: dblock <[email protected]> --------- Signed-off-by: dblock <[email protected]> Signed-off-by: Nathalie Jonathan <[email protected]>
nathaliellenaa
pushed a commit
to nathaliellenaa/opensearch-api-specification
that referenced
this pull request
Jan 7, 2025
* Added tests for /_validate/query. Signed-off-by: dblock <[email protected]> * Added retry for opensearch-project#738. Signed-off-by: dblock <[email protected]> --------- Signed-off-by: dblock <[email protected]> Signed-off-by: Nathalie Jonathan <[email protected]>
nathaliellenaa
pushed a commit
to nathaliellenaa/opensearch-api-specification
that referenced
this pull request
Jan 9, 2025
* Added tests for /_validate/query. Signed-off-by: dblock <[email protected]> * Added retry for opensearch-project#738. Signed-off-by: dblock <[email protected]> --------- Signed-off-by: dblock <[email protected]> Signed-off-by: Nathalie Jonathan <[email protected]>
dblock
added a commit
that referenced
this pull request
Jan 9, 2025
* Added ML Model APIs (get, search, update model) to the spec along with the tests Signed-off-by: Nathalie Jonathan <[email protected]> * Added ML Model APIs (undeploy, unload), moved test for search model to models/search.yaml, resolved conflicts and updated CHANGELOG Signed-off-by: Nathalie Jonathan <[email protected]> * Added support for using a certificate and key. (#731) Signed-off-by: dblock <[email protected]> Signed-off-by: Nathalie Jonathan <[email protected]> * Fixed /_search/scroll/{scroll_id}, missing search tests. (#732) * Fixed /_search/scroll. Signed-off-by: dblock <[email protected]> * Added tests for GET and POST /_search. Signed-off-by: dblock <[email protected]> * Added a test for GET /_search/pipeline and DELETE /_search/pipeline/{id}. Signed-off-by: dblock <[email protected]> * Added missing _search/point_in_time tests. Signed-off-by: dblock <[email protected]> --------- Signed-off-by: dblock <[email protected]> Signed-off-by: Nathalie Jonathan <[email protected]> * Added tests for /_validate/query. (#739) * Added tests for /_validate/query. Signed-off-by: dblock <[email protected]> * Added retry for #738. Signed-off-by: dblock <[email protected]> --------- Signed-off-by: dblock <[email protected]> Signed-off-by: Nathalie Jonathan <[email protected]> * Fixed lint and directory path error. Signed-off-by: Nathalie Jonathan <[email protected]> * Added ML Model APIs (load, upload, create metadata). Signed-off-by: Nathalie Jonathan <[email protected]> * Added ML Model APIs (predict) and updated the test settings for metadata. Signed-off-by: Nathalie Jonathan <[email protected]> * Fixed lint errors in predict.yaml, moved setup to prologues and teardown to epilogues in predict.yaml and load.yaml, updated CHANGELOG format, updated API description, 'model_group_id' ID type, 'version' parameter, and made 'model_format' a type of its own in ml.yaml. Signed-off-by: Nathalie Jonathan <[email protected]> * Added ML Model APIs (chunk, register meta), updated CHANGELOG and test for deprecated model metadata creation API. Signed-off-by: Nathalie Jonathan <[email protected]> * Added ML Model APIs (upload chunk), moved test for deprecated chunk upload to create_metadata.yaml, updated CHANGELOG. Signed-off-by: Nathalie Jonathan <[email protected]> * Applied suggestions from code review. Signed-off-by: Nathalie Jonathan <[email protected]> * Merged main and resolve conflicts. Signed-off-by: Nathalie Jonathan <[email protected]> * Moved test models folder to tests/plugins/ml/ml/models, removed duplicate map keys in ml._common.yaml, removed excluded parts and until property in the test files. Signed-off-by: Nathalie Jonathan <[email protected]> * Fixed merge conflicts, added support for payload properties into the prologue, attempted to fix errors in predict.yaml. Signed-off-by: Nathalie Jonathan <[email protected]> * Rebase with main, fixed test-spec.yml content, added response property in prologues of predict.yaml, undeploy.yaml, unload.yaml, added version for ML Model APIs. Signed-off-by: Nathalie Jonathan <[email protected]> * Modified response payload state from RUNNING to COMPLETED. Signed-off-by: Nathalie Jonathan <[email protected]> --------- Signed-off-by: Nathalie Jonathan <[email protected]> Signed-off-by: dblock <[email protected]> Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added tests for /_validate/query.
Issues Resolved
Part of #663.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.