Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for /_validate/query. #739

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

dblock
Copy link
Member

@dblock dblock commented Dec 16, 2024

Description

Added tests for /_validate/query.

Issues Resolved

Part of #663.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock dblock added the skip-changelog No need to update CHANGELOG. label Dec 16, 2024
Copy link
Contributor

github-actions bot commented Dec 16, 2024

Changes Analysis

Commit SHA: a53c487
Comparing To SHA: 150159b

API Changes

Summary

NO CHANGES

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/12374890324/artifacts/2332259069

API Coverage

Before After Δ
Covered (%) 606 (59.35 %) 606 (59.35 %) 0 (0 %)
Uncovered (%) 415 (40.65 %) 415 (40.65 %) 0 (0 %)
Unknown 43 43 0

Copy link
Contributor

Spec Test Coverage Analysis

Total Tested
536 514 (95.9 %)

Copy link
Collaborator

@Tokesh Tokesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM!

@Tokesh Tokesh merged commit eb948fb into opensearch-project:main Dec 17, 2024
27 checks passed
nathaliellenaa pushed a commit to nathaliellenaa/opensearch-api-specification that referenced this pull request Dec 17, 2024
* Added tests for /_validate/query.

Signed-off-by: dblock <[email protected]>

* Added retry for opensearch-project#738.

Signed-off-by: dblock <[email protected]>

---------

Signed-off-by: dblock <[email protected]>
nathaliellenaa pushed a commit to nathaliellenaa/opensearch-api-specification that referenced this pull request Dec 18, 2024
* Added tests for /_validate/query.

Signed-off-by: dblock <[email protected]>

* Added retry for opensearch-project#738.

Signed-off-by: dblock <[email protected]>

---------

Signed-off-by: dblock <[email protected]>
Signed-off-by: Nathalie Jonathan <[email protected]>
nathaliellenaa pushed a commit to nathaliellenaa/opensearch-api-specification that referenced this pull request Jan 7, 2025
* Added tests for /_validate/query.

Signed-off-by: dblock <[email protected]>

* Added retry for opensearch-project#738.

Signed-off-by: dblock <[email protected]>

---------

Signed-off-by: dblock <[email protected]>
Signed-off-by: Nathalie Jonathan <[email protected]>
nathaliellenaa pushed a commit to nathaliellenaa/opensearch-api-specification that referenced this pull request Jan 9, 2025
* Added tests for /_validate/query.

Signed-off-by: dblock <[email protected]>

* Added retry for opensearch-project#738.

Signed-off-by: dblock <[email protected]>

---------

Signed-off-by: dblock <[email protected]>
Signed-off-by: Nathalie Jonathan <[email protected]>
dblock added a commit that referenced this pull request Jan 9, 2025
* Added ML Model APIs (get, search, update model) to the spec along with the tests

Signed-off-by: Nathalie Jonathan <[email protected]>

* Added ML Model APIs (undeploy, unload), moved test for search model to models/search.yaml, resolved conflicts and updated CHANGELOG

Signed-off-by: Nathalie Jonathan <[email protected]>

* Added support for using a certificate and key. (#731)

Signed-off-by: dblock <[email protected]>
Signed-off-by: Nathalie Jonathan <[email protected]>

* Fixed /_search/scroll/{scroll_id}, missing search tests. (#732)

* Fixed /_search/scroll.

Signed-off-by: dblock <[email protected]>

* Added tests for GET and POST /_search.

Signed-off-by: dblock <[email protected]>

* Added a test for GET /_search/pipeline and DELETE /_search/pipeline/{id}.

Signed-off-by: dblock <[email protected]>

* Added missing _search/point_in_time tests.

Signed-off-by: dblock <[email protected]>

---------

Signed-off-by: dblock <[email protected]>
Signed-off-by: Nathalie Jonathan <[email protected]>

* Added tests for /_validate/query. (#739)

* Added tests for /_validate/query.

Signed-off-by: dblock <[email protected]>

* Added retry for #738.

Signed-off-by: dblock <[email protected]>

---------

Signed-off-by: dblock <[email protected]>
Signed-off-by: Nathalie Jonathan <[email protected]>

* Fixed lint and directory path error.

Signed-off-by: Nathalie Jonathan <[email protected]>

* Added ML Model APIs (load, upload, create metadata).

Signed-off-by: Nathalie Jonathan <[email protected]>

* Added ML Model APIs (predict) and updated the test settings for metadata.

Signed-off-by: Nathalie Jonathan <[email protected]>

* Fixed lint errors in predict.yaml, moved setup to prologues and teardown to epilogues in predict.yaml and load.yaml, updated CHANGELOG format, updated API description, 'model_group_id' ID type, 'version' parameter, and made 'model_format' a type of its own in ml.yaml.

Signed-off-by: Nathalie Jonathan <[email protected]>

* Added ML Model APIs (chunk, register meta), updated CHANGELOG and test for deprecated model metadata creation API.

Signed-off-by: Nathalie Jonathan <[email protected]>

* Added ML Model APIs (upload chunk), moved test for deprecated chunk upload to create_metadata.yaml, updated CHANGELOG.

Signed-off-by: Nathalie Jonathan <[email protected]>

* Applied suggestions from code review.

Signed-off-by: Nathalie Jonathan <[email protected]>

* Merged main and resolve conflicts.

Signed-off-by: Nathalie Jonathan <[email protected]>

* Moved test models folder to tests/plugins/ml/ml/models, removed duplicate map keys in ml._common.yaml, removed excluded parts and until property in the test files.

Signed-off-by: Nathalie Jonathan <[email protected]>

* Fixed merge conflicts, added support for payload properties into the prologue, attempted to fix errors in predict.yaml.

Signed-off-by: Nathalie Jonathan <[email protected]>

* Rebase with main, fixed test-spec.yml content, added response property in prologues of predict.yaml, undeploy.yaml, unload.yaml, added version for ML Model APIs.

Signed-off-by: Nathalie Jonathan <[email protected]>

* Modified response payload state from RUNNING to COMPLETED.

Signed-off-by: Nathalie Jonathan <[email protected]>

---------

Signed-off-by: Nathalie Jonathan <[email protected]>
Signed-off-by: dblock <[email protected]>
Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No need to update CHANGELOG.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants