Skip to content

Remove measure field #1258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kavithacm merged 3 commits into from
Nov 4, 2022
Merged

Remove measure field #1258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ee1a59c
remove measure
kavithacm Nov 4, 2022
2aff898
remove comments
kavithacm Nov 4, 2022
43b8d84
update jest test
kavithacm Nov 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions dashboards-observability/public/components/event_analytics/explorer/explorer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1247,7 +1247,6 @@ export const Explorer = ({
: JSON.stringify({}),
description: vizDescription,
subType: subType,
unitsOfMeasure: metricMeasure,
})
.then((res: any) => {
setToast(
Expand Down Expand Up @@ -1283,7 +1282,6 @@ export const Explorer = ({
: JSON.stringify({}),
description: vizDescription,
subType: subType,
unitsOfMeasure: metricMeasure,
})
.then((res: any) => {
batch(() => {
Expand Down
193 changes: 0 additions & 193 deletions ...ents/event_analytics/explorer/save_panel/__tests__/__snapshots__/save_panel.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -787,198 +787,5 @@ exports[`Saved query table component Renders saved query table 1`] = `
</div>
</div>
</EuiFormRow>
<EuiSpacer
size="s"
>
<div
className="euiSpacer euiSpacer--s"
/>
</EuiSpacer>
<EuiTitle
size="xxs"
>
<h3
className="euiTitle euiTitle--xxsmall"
>
Units of Measure
</h3>
</EuiTitle>
<EuiFormRow
describedByIds={Array []}
display="row"
fullWidth={false}
hasChildLabel={true}
hasEmptyLabelSpace={false}
labelType="label"
>
<div
className="euiFormRow"
id="random_html_id-row"
>
<div
className="euiFormRow__fieldWrapper"
>
<EuiSelect
data-test-subj="eventExplorer__metricMeasureSaveSelectBox"
id="random_html_id"
onBlur={[Function]}
onChange={[Function]}
onFocus={[Function]}
options={
Array [
Object {
"text": "seconds (s)",
"value": "seconds (s)",
},
Object {
"text": "hours (h)",
"value": "hours (h)",
},
Object {
"text": "celsius (C)",
"value": "celsius (C)",
},
Object {
"text": "farenheit (F)",
"value": "farenheit (F)",
},
Object {
"text": "meters (m)",
"value": "meters (m)",
},
Object {
"text": "kilometers (k)",
"value": "kilometers (k)",
},
]
}
placeholder="Select measure"
value="hours (h)"
>
<EuiFormControlLayout
compressed={false}
fullWidth={false}
icon={
Object {
"side": "right",
"type": "arrowDown",
}
}
inputId="random_html_id"
isLoading={false}
>
<div
className="euiFormControlLayout"
>
<div
className="euiFormControlLayout__childrenWrapper"
>
<EuiValidatableControl>
<select
className="euiSelect"
data-test-subj="eventExplorer__metricMeasureSaveSelectBox"
id="random_html_id"
onBlur={[Function]}
onChange={[Function]}
onFocus={[Function]}
onMouseUp={[Function]}
placeholder="Select measure"
value="hours (h)"
>
<option
key="0"
value="seconds (s)"
>
seconds (s)
</option>
<option
key="1"
value="hours (h)"
>
hours (h)
</option>
<option
key="2"
value="celsius (C)"
>
celsius (C)
</option>
<option
key="3"
value="farenheit (F)"
>
farenheit (F)
</option>
<option
key="4"
value="meters (m)"
>
meters (m)
</option>
<option
key="5"
value="kilometers (k)"
>
kilometers (k)
</option>
</select>
</EuiValidatableControl>
<EuiFormControlLayoutIcons
compressed={false}
icon={
Object {
"side": "right",
"type": "arrowDown",
}
}
isLoading={false}
>
<div
className="euiFormControlLayoutIcons euiFormControlLayoutIcons--right"
>
<EuiFormControlLayoutCustomIcon
size="m"
type="arrowDown"
>
<span
className="euiFormControlLayoutCustomIcon"
>
<EuiIcon
aria-hidden="true"
className="euiFormControlLayoutCustomIcon__icon"
size="m"
type="arrowDown"
>
<EuiIconEmpty
aria-hidden={true}
className="euiIcon euiIcon--medium euiIcon-isLoading euiFormControlLayoutCustomIcon__icon"
focusable="false"
role="img"
style={null}
>
<svg
aria-hidden={true}
className="euiIcon euiIcon--medium euiIcon-isLoading euiFormControlLayoutCustomIcon__icon"
focusable="false"
height={16}
role="img"
style={null}
viewBox="0 0 16 16"
width={16}
xmlns="http://www.w3.org/2000/svg"
/>
</EuiIconEmpty>
</EuiIcon>
</span>
</EuiFormControlLayoutCustomIcon>
</div>
</EuiFormControlLayoutIcons>
</div>
</div>
</EuiFormControlLayout>
</EuiSelect>
</div>
</div>
</EuiFormRow>
</SavePanel>
`;
19 changes: 0 additions & 19 deletions ...boards-observability/public/components/event_analytics/explorer/save_panel/save_panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,25 +158,6 @@ export const SavePanel = ({
/>
</EuiToolTip>
</EuiFormRow>
{checked && (
<>
<EuiSpacer size="s" />
<EuiTitle size="xxs">
<h3>{'Units of Measure'}</h3>
</EuiTitle>
<EuiFormRow>
<EuiSelect
placeholder="Select measure"
value={measure}
onChange={(e) => onMeasureChange(e.target.value)}
options={UNITS_OF_MEASURE.map((i) => {
return { value: i, text: i };
})}
data-test-subj="eventExplorer__metricMeasureSaveSelectBox"
/>
</EuiFormRow>
</>
)}
</>
)}
</>
Expand Down
12 changes: 6 additions & 6 deletions ...rvability/public/components/metrics/sidebar/__tests__/__snapshots__/sidebar.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ exports[`Side Bar Component renders Side Bar Component 1`] = `
initialIsOpen={true}
isLoading={false}
isLoadingMessage={false}
paddingSize="xs"
paddingSize="none"
>
<div
className="euiAccordion euiAccordion-isOpen"
Expand Down Expand Up @@ -197,7 +197,7 @@ exports[`Side Bar Component renders Side Bar Component 1`] = `
>
<div>
<div
className="euiAccordion__padding--xs"
className=""
>
<ul
className="metricsList"
Expand Down Expand Up @@ -230,7 +230,7 @@ exports[`Side Bar Component renders Side Bar Component 1`] = `
initialIsOpen={true}
isLoading={false}
isLoadingMessage={false}
paddingSize="xs"
paddingSize="none"
>
<div
className="euiAccordion euiAccordion-isOpen"
Expand Down Expand Up @@ -302,7 +302,7 @@ exports[`Side Bar Component renders Side Bar Component 1`] = `
>
<div>
<div
className="euiAccordion__padding--xs"
className=""
>
<ul
className="metricsList"
Expand Down Expand Up @@ -335,7 +335,7 @@ exports[`Side Bar Component renders Side Bar Component 1`] = `
initialIsOpen={true}
isLoading={false}
isLoadingMessage={false}
paddingSize="xs"
paddingSize="none"
>
<div
className="euiAccordion euiAccordion-isOpen"
Expand Down Expand Up @@ -407,7 +407,7 @@ exports[`Side Bar Component renders Side Bar Component 1`] = `
>
<div>
<div
className="euiAccordion__padding--xs"
className=""
>
<ul
className="metricsList"
Expand Down