Skip to content

Use in-memory count for total hits in patterns ratio #1254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshuali925 merged 1 commit into from
Nov 4, 2022
Merged

Use in-memory count for total hits in patterns ratio #1254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions dashboards-observability/public/components/event_analytics/explorer/explorer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -879,11 +879,6 @@ export const Explorer = ({
tabId={tabId}
query={query}
isPatternLoading={isPatternLoading}
totalHits={reduce(
countDistribution.data['count()'],
(sum, n) => sum + n,
0
)}
/>
<EuiHorizontalRule margin="xs" />
</>
Expand Down
6 changes: 2 additions & 4 deletions ...-observability/public/components/event_analytics/explorer/log_patterns/patterns_table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,11 @@ interface PatternsTableProps {
tabId: string;
query: any;
isPatternLoading: boolean;
totalHits?: number;
}

export function PatternsTable(props: PatternsTableProps) {
const { tableData, tabId, onPatternSelection, query } = props;
const patternsData = useSelector(selectPatterns)[tabId];
Copy link
Copy Markdown
Collaborator

@derek-ho derek-ho Nov 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was patternsData just never used?

Copy link
Copy Markdown
Member Author

@joshuali925 joshuali925 Nov 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

patternsData used to contain the results of stats count() as total hit, forgot to remove it since i removed stats count() call

const totalHits = props.totalHits || tableData.reduce((p, v) => p + v.count, 0);
const { tableData, onPatternSelection, query } = props;
const totalHits = tableData.reduce((p, v) => p + v.count, 0);

const tableColumns = [
{
Expand Down