Skip to content

Backtick supports, issues fixes#1250

Merged
mengweieric merged 6 commits intoopensearch-project:2.4from
mengweieric:issue-backtick
Nov 4, 2022
Merged

Backtick supports, issues fixes#1250
mengweieric merged 6 commits intoopensearch-project:2.4from
mengweieric:issue-backtick

Conversation

@mengweieric
Copy link
Collaborator

@mengweieric mengweieric commented Nov 4, 2022

Description

  • wrap backtick for any field piped to query builder and proper rendering
  • timeseries only has timestamp field in selector
  • Pie/heatmap rendering issue

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@mengweieric mengweieric requested a review from a team as a code owner November 4, 2022 15:54
@codecov-commenter
Copy link

Codecov Report

Merging #1250 (26cdef0) into 2.4 (bfda43a) will decrease coverage by 20.27%.
The diff coverage is 56.14%.

@@              Coverage Diff              @@
##                2.4    #1250       +/-   ##
=============================================
- Coverage     70.27%   49.99%   -20.28%     
=============================================
  Files            42      242      +200     
  Lines          2395     7431     +5036     
  Branches        248     2050     +1802     
=============================================
+ Hits           1683     3715     +2032     
- Misses          571     3685     +3114     
+ Partials        141       31      -110     
Flag Coverage Δ
dashboards-observability 49.99% <56.14%> (?)
opensearch-observability ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ty/common/query_manager/ast/expression/group_by.ts 50.00% <0.00%> (ø)
...alizations/shared_components/empty_placeholder.tsx 100.00% <ø> (ø)
...public/components/visualizations/visualization.tsx 60.00% <0.00%> (ø)
...ts/visualizations/charts/data_table/data_table.tsx 44.21% <20.00%> (ø)
.../components/visualizations/charts/maps/heatmap.tsx 22.07% <44.44%> (ø)
...ublic/components/visualizations/charts/pie/pie.tsx 43.33% <50.00%> (ø)
.../components/visualizations/charts/shared/common.ts 89.58% <84.61%> (ø)
...shboards-observability/common/utils/query_utils.ts 19.14% <100.00%> (ø)
...ions/shared_components/vis_canvass_placeholder.tsx 100.00% <100.00%> (ø)
.../public/components/event_analytics/utils/utils.tsx 56.28% <100.00%> (ø)
... and 285 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mengweieric mengweieric merged commit 28c436b into opensearch-project:2.4 Nov 4, 2022
@mengweieric mengweieric deleted the issue-backtick branch November 4, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants