Skip to content

Conversation

@mengweieric
Copy link
Collaborator

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
@mengweieric mengweieric requested a review from a team as a code owner November 3, 2022 16:37
anirudha
anirudha previously approved these changes Nov 3, 2022
joshuali925
joshuali925 previously approved these changes Nov 3, 2022
Signed-off-by: Eric Wei <menwe@amazon.com>
anirudha
anirudha previously approved these changes Nov 3, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2022

Codecov Report

Merging #1235 (d8d1875) into 2.4 (14a7455) will increase coverage by 17.44%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##                2.4    #1235       +/-   ##
=============================================
+ Coverage     52.91%   70.35%   +17.44%     
  Complexity      292      292               
=============================================
  Files           283       42      -241     
  Lines          9766     2392     -7374     
  Branches       2284      248     -2036     
=============================================
- Hits           5168     1683     -3485     
+ Misses         4427      568     -3859     
+ Partials        171      141       -30     
Flag Coverage Δ
dashboards-observability ?
opensearch-observability 70.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../public/components/custom_panels/helpers/utils.tsx
.../public/components/event_analytics/utils/utils.tsx
...c/components/visualizations/charts/bar/bar_type.ts
...isualizations/charts/data_table/data_table_type.ts
...omponents/visualizations/charts/lines/line_type.ts
...ents/visualizations/charts/metrics/metrics_type.ts
...ytics/components/common/filters/filter_helpers.tsx
...nts/event_analytics/redux/slices/patterns_slice.ts
...e_analytics/components/services/services_table.tsx
...tics/components/common/plots/service_map_scale.tsx
... and 231 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Eric Wei <menwe@amazon.com>
@mengweieric mengweieric merged commit 1381c57 into opensearch-project:2.4 Nov 3, 2022
@mengweieric mengweieric deleted the issues-remaining branch November 3, 2022 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants