Skip to content

Removal of NotificationEvent Request, Response and SearchResults #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qreshi merged 9 commits into from
Apr 8, 2022
Merged

Removal of NotificationEvent Request, Response and SearchResults #395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
620b23d
Changes to NotificationPlugin/EventIndexingActions/SendMessageActionH…
Apr 2, 2022
ca6dad6
Changes to PluginActionTests/NotificationEventIndexTests
Apr 3, 2022
a9dd1d5
Remove Events from QueryNotificationEvent and SendTestMessageRestHand…
Apr 3, 2022
7cbb5f8
Remove Metadata from NotificationEventDocTests
Apr 3, 2022
0c43ae7
Remove UTs for the Event Actions
Apr 3, 2022
6a9ebb4
Removing Commented Out Files
Apr 3, 2022
d456f0f
Remove Unused Imports
Apr 4, 2022
ccb3da6
Remove NotificationEventDoc and NotificationEventDocTests
Apr 4, 2022
8fbfbc2
Cleanup
Apr 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions ...ications/notifications/src/main/kotlin/org/opensearch/notifications/NotificationPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,19 +26,15 @@ import org.opensearch.notifications.action.CreateNotificationConfigAction
import org.opensearch.notifications.action.DeleteNotificationConfigAction
import org.opensearch.notifications.action.GetChannelListAction
import org.opensearch.notifications.action.GetNotificationConfigAction
import org.opensearch.notifications.action.GetNotificationEventAction
import org.opensearch.notifications.action.GetPluginFeaturesAction
import org.opensearch.notifications.action.PublishNotificationAction
import org.opensearch.notifications.action.SendNotificationAction
import org.opensearch.notifications.action.SendTestNotificationAction
import org.opensearch.notifications.action.UpdateNotificationConfigAction
import org.opensearch.notifications.index.ConfigIndexingActions
import org.opensearch.notifications.index.EventIndexingActions
import org.opensearch.notifications.index.NotificationConfigIndex
import org.opensearch.notifications.index.NotificationEventIndex
import org.opensearch.notifications.resthandler.NotificationChannelListRestHandler
import org.opensearch.notifications.resthandler.NotificationConfigRestHandler
import org.opensearch.notifications.resthandler.NotificationEventRestHandler
import org.opensearch.notifications.resthandler.NotificationFeaturesRestHandler
import org.opensearch.notifications.resthandler.NotificationStatsRestHandler
import org.opensearch.notifications.resthandler.SendTestMessageRestHandler
Expand Down Expand Up @@ -105,10 +101,8 @@ class NotificationPlugin : ActionPlugin, Plugin(), NotificationCoreExtension {
this.clusterService = clusterService
PluginSettings.addSettingsUpdateConsumer(clusterService)
NotificationConfigIndex.initialize(client, clusterService)
NotificationEventIndex.initialize(client, clusterService)
ConfigIndexingActions.initialize(NotificationConfigIndex, UserAccessManager)
SendMessageActionHelper.initialize(NotificationConfigIndex, NotificationEventIndex, UserAccessManager)
EventIndexingActions.initialize(NotificationEventIndex, UserAccessManager)
SendMessageActionHelper.initialize(NotificationConfigIndex, UserAccessManager)
return listOf()
}

Expand All @@ -135,10 +129,6 @@ class NotificationPlugin : ActionPlugin, Plugin(), NotificationCoreExtension {
NotificationsActions.GET_NOTIFICATION_CONFIG_ACTION_TYPE,
GetNotificationConfigAction::class.java
),
ActionPlugin.ActionHandler(
NotificationsActions.GET_NOTIFICATION_EVENT_ACTION_TYPE,
GetNotificationEventAction::class.java
),
ActionPlugin.ActionHandler(
NotificationsActions.GET_CHANNEL_LIST_ACTION_TYPE,
GetChannelListAction::class.java
Expand Down Expand Up @@ -173,7 +163,6 @@ class NotificationPlugin : ActionPlugin, Plugin(), NotificationCoreExtension {
log.debug("$LOG_PREFIX:getRestHandlers")
return listOf(
NotificationConfigRestHandler(),
NotificationEventRestHandler(),
NotificationFeaturesRestHandler(),
NotificationChannelListRestHandler(),
SendTestMessageRestHandler(),
Expand Down
62 changes: 0 additions & 62 deletions ...cations/src/main/kotlin/org/opensearch/notifications/action/GetNotificationEventAction.kt
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion ...cations/src/main/kotlin/org/opensearch/notifications/action/SendTestNotificationAction.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ internal class SendTestNotificationAction @Inject constructor(
channelIds,
object : ActionListener<SendNotificationResponse> {
override fun onResponse(sendNotificationResponse: SendNotificationResponse) {
log.info("$LOG_PREFIX:SendTestNotificationAction-send:${sendNotificationResponse.notificationId}")
log.info("$LOG_PREFIX:SendTestNotificationAction-send:${sendNotificationResponse.notificationEvent}")
listener.onResponse(sendNotificationResponse)
}

Expand Down
131 changes: 0 additions & 131 deletions .../notifications/src/main/kotlin/org/opensearch/notifications/index/EventIndexingActions.kt
View file
Open in desktop

This file was deleted.

72 changes: 0 additions & 72 deletions ...tions/notifications/src/main/kotlin/org/opensearch/notifications/index/EventOperations.kt
View file
Open in desktop

This file was deleted.

Loading