-
Notifications
You must be signed in to change notification settings - Fork 104
Fix ingest document wrapper constructor compilation errors in unit tests #1383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ingest document wrapper constructor compilation errors in unit tests #1383
Conversation
Signed-off-by: Andy Qin <[email protected]>
|
Looks good, let's wait for CI action to pass. |
|
Update operations also use To do this, in opensearch-project/OpenSearch#18277 we introduce a new In this case 0 just means that the document being processed is either an index request, or the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1383 +/- ##
============================================
- Coverage 79.80% 0 -79.81%
============================================
Files 159 0 -159
Lines 8291 0 -8291
Branches 1335 0 -1335
============================================
- Hits 6617 0 -6617
+ Misses 1161 0 -1161
+ Partials 513 0 -513 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4cd9220
into
opensearch-project:main
Signed-off-by: Andy Qin <[email protected]> (cherry picked from commit 4cd9220)
(cherry picked from commit 4cd9220) Signed-off-by: Andy Qin <[email protected]> Co-authored-by: Andy <[email protected]>
Description
Fixes compilation error from core 3.1
With opensearch-project/OpenSearch#18277 in core, we introduce a new parameter to the constructor of IngestDocumentWrapper. AbstractBatchingProcessor interacts with IngestDocumentWrappers directly so we need to update the constructor usages to fix compilation error in #1382 1382
Related Issues
n/a
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.