Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix no permission to update model group index #948

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

ylwu-amzn
Copy link
Collaborator

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Merging #948 (f439b0d) into 2.x (d2b847e) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                2.x     #948      +/-   ##
============================================
- Coverage     82.30%   82.29%   -0.02%     
  Complexity     1913     1913              
============================================
  Files           149      149              
  Lines          7494     7499       +5     
  Branches        744      744              
============================================
+ Hits           6168     6171       +3     
- Misses          985      986       +1     
- Partials        341      342       +1     
Flag Coverage Δ
ml-commons 82.29% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...n/model_group/TransportUpdateModelGroupAction.java 87.50% <100.00%> (+0.68%) ⬆️

... and 1 file with indirect coverage changes

@rbhavna rbhavna merged commit da5db17 into opensearch-project:2.x Jun 1, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 1, 2023
Signed-off-by: Yaliang Wu <[email protected]>
(cherry picked from commit da5db17)
rbhavna pushed a commit that referenced this pull request Jun 1, 2023
Signed-off-by: Yaliang Wu <[email protected]>
(cherry picked from commit da5db17)

Co-authored-by: Yaliang Wu <[email protected]>
zane-neo pushed a commit to zane-neo/ml-commons that referenced this pull request Aug 25, 2023
zane-neo added a commit that referenced this pull request Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants