Skip to content

[Backport 2.5] Add native memory circuit breaker.#693

Merged
ylwu-amzn merged 1 commit into2.5from
backport/backport-689-to-2.5
Jan 11, 2023
Merged

[Backport 2.5] Add native memory circuit breaker.#693
ylwu-amzn merged 1 commit into2.5from
backport/backport-689-to-2.5

Conversation

@opensearch-trigger-bot
Copy link
Contributor

Backport d809dd2 from #689

* Add native memory circuit breaker.
Refactor all breakers from common to plugin.
Add dynamic setting for native memory circuit breaker.

Signed-off-by: Jing Zhang <jngz@amazon.com>

* Address the comments 1.

Signed-off-by: Jing Zhang <jngz@amazon.com>

* Spotless changes.

Signed-off-by: Jing Zhang <jngz@amazon.com>

* Address the comments 2.

Signed-off-by: Jing Zhang <jngz@amazon.com>

Signed-off-by: Jing Zhang <jngz@amazon.com>
(cherry picked from commit d809dd2)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team January 11, 2023 02:42
@ylwu-amzn ylwu-amzn merged commit 2b0eb5c into 2.5 Jan 11, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #693 (d809dd2) into 2.5 (684235a) will increase coverage by 0.17%.
The diff coverage is 77.77%.

❗ Current head d809dd2 differs from pull request most recent head ca0f5f0. Consider uploading reports for the commit ca0f5f0 to get more accurate results

@@             Coverage Diff              @@
##                2.5     #693      +/-   ##
============================================
+ Coverage     83.31%   83.49%   +0.17%     
- Complexity      994     1021      +27     
============================================
  Files            93       99       +6     
  Lines          3662     3738      +76     
  Branches        343      344       +1     
============================================
+ Hits           3051     3121      +70     
- Misses          464      470       +6     
  Partials        147      147              
Flag Coverage Δ
ml-commons 83.49% <77.77%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ml/action/load/TransportLoadModelOnNodeAction.java 97.29% <ø> (ø)
...h/ml/action/upload/TransportUploadModelAction.java 98.63% <ø> (ø)
.../org/opensearch/ml/breaker/DiskCircuitBreaker.java 36.36% <0.00%> (ø)
...rg/opensearch/ml/breaker/MemoryCircuitBreaker.java 100.00% <ø> (ø)
...opensearch/ml/breaker/ThresholdCircuitBreaker.java 100.00% <ø> (ø)
...ain/java/org/opensearch/ml/model/MLModelCache.java 86.36% <ø> (ø)
...n/java/org/opensearch/ml/model/MLModelManager.java 78.20% <0.00%> (ø)
...va/org/opensearch/ml/task/MLExecuteTaskRunner.java 83.33% <ø> (ø)
...va/org/opensearch/ml/task/MLPredictTaskRunner.java 82.14% <ø> (ø)
.../java/org/opensearch/ml/task/MLTaskDispatcher.java 32.94% <0.00%> (ø)
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions github-actions bot deleted the backport/backport-689-to-2.5 branch January 11, 2023 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants