Skip to content

[Backport 2.5] Adding backwards compatibility test for ml-commons plugin#690

Closed
opensearch-trigger-bot[bot] wants to merge 1 commit into2.5from
backport/backport-681-to-2.5
Closed

[Backport 2.5] Adding backwards compatibility test for ml-commons plugin#690
opensearch-trigger-bot[bot] wants to merge 1 commit into2.5from
backport/backport-681-to-2.5

Conversation

@opensearch-trigger-bot
Copy link
Contributor

Backport e37ab93 from #681

* Adding backwards compatibility test for ml-commons plugin

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>

* Adjust gradle build file to create bwc tasks

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>

* Add bwc test to CI workflow and developer guide

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>

* Add gradle test filter so BWC test can only run within the BWC gradle task bwcsuite or its dependent tasks

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>

* bug fix for bwc test

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>

* Fix running on ml node issue

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
(cherry picked from commit e37ab93)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team January 11, 2023 00:49
@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2023

Codecov Report

Merging #690 (e37ab93) into 2.5 (0aa08cf) will increase coverage by 0.70%.
The diff coverage is 25.00%.

❗ Current head e37ab93 differs from pull request most recent head b6593ce. Consider uploading reports for the commit b6593ce to get more accurate results

@@             Coverage Diff              @@
##                2.5     #690      +/-   ##
============================================
+ Coverage     83.42%   84.13%   +0.70%     
- Complexity      996     1010      +14     
============================================
  Files            93       93              
  Lines          3662     3662              
  Branches        343      343              
============================================
+ Hits           3055     3081      +26     
+ Misses          461      436      -25     
+ Partials        146      145       -1     
Flag Coverage Δ
ml-commons 84.13% <25.00%> (+0.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...h/ml/action/upload/TransportUploadModelAction.java 98.63% <ø> (ø)
...ain/java/org/opensearch/ml/model/MLModelCache.java 86.36% <ø> (ø)
...n/java/org/opensearch/ml/model/MLModelManager.java 78.20% <0.00%> (ø)
.../java/org/opensearch/ml/task/MLTaskDispatcher.java 32.94% <0.00%> (ø)
.../org/opensearch/ml/settings/MLCommonsSettings.java 100.00% <100.00%> (ø)
.../ml/action/syncup/TransportSyncUpOnNodeAction.java 89.79% <0.00%> (+4.08%) ⬆️
...n/java/org/opensearch/ml/cluster/MLSyncUpCron.java 93.75% <0.00%> (+6.25%) ⬆️
...ain/java/org/opensearch/ml/task/MLTaskManager.java 65.98% <0.00%> (+6.59%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ylwu-amzn
Copy link
Collaborator

DCO check failed ,

b6593ce63279457f9a4a737efa0f5656892c5b22    Can not find "Sicheng Song <114637679+b4sjoo@users.noreply.github.com>", in ["Sicheng Song <sicheng.song@outlook.com>", "Sicheng Song <sicheng.song@outlook.com>", "Sicheng Song <sicheng.song@outlook.com>", "Sicheng Song <sicheng.song@outlook.com>", "Sicheng Song <sicheng.song@outlook.com>", "Sicheng Song <sicheng.song@outlook.com>", "Sicheng Song <sicheng.song@outlook.com>"].

Sicheng published a new PR to manually backport #691

@ylwu-amzn ylwu-amzn closed this Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants