Skip to content

Conversation

@peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented Jul 29, 2021

Description

Resolve the gem building errors before docker creation

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has documentation added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peterzhuamazon peterzhuamazon requested a review from VijayanB July 29, 2021 20:10
@peterzhuamazon peterzhuamazon changed the title Tweak and improve the docker script comments Resolve the gem building errors before docker creation Jul 29, 2021
@peterzhuamazon peterzhuamazon merged commit 2c8437c into main Jul 29, 2021
@peterzhuamazon peterzhuamazon deleted the opensearch-logstash-multiarch branch July 29, 2021 22:33
VijayanB pushed a commit to VijayanB/logstash-output-opensearch that referenced this pull request Aug 5, 2021
…oject#43)

* Add new docker building scripts for logstash

Signed-off-by: Peter Zhu <[email protected]>

* Move build related vars to the top

Signed-off-by: Peter Zhu <[email protected]>

* Tweak and improve the docker script comments

Signed-off-by: Peter Zhu <[email protected]>

* Resolve gem building incorrectly due to move of spec files

Signed-off-by: Peter Zhu <[email protected]>
@VijayanB VijayanB mentioned this pull request Aug 5, 2021
5 tasks
VijayanB pushed a commit to VijayanB/logstash-output-opensearch that referenced this pull request Aug 5, 2021
…oject#43)

* Add new docker building scripts for logstash

Signed-off-by: Peter Zhu <[email protected]>

* Move build related vars to the top

Signed-off-by: Peter Zhu <[email protected]>

* Tweak and improve the docker script comments

Signed-off-by: Peter Zhu <[email protected]>

* Resolve gem building incorrectly due to move of spec files

Signed-off-by: Peter Zhu <[email protected]>
This was referenced Aug 5, 2021
VijayanB pushed a commit to VijayanB/logstash-output-opensearch that referenced this pull request Aug 5, 2021
…oject#43)

* Add new docker building scripts for logstash

Signed-off-by: Peter Zhu <[email protected]>

* Move build related vars to the top

Signed-off-by: Peter Zhu <[email protected]>

* Tweak and improve the docker script comments

Signed-off-by: Peter Zhu <[email protected]>

* Resolve gem building incorrectly due to move of spec files

Signed-off-by: Peter Zhu <[email protected]>
@VijayanB VijayanB mentioned this pull request Aug 5, 2021
5 tasks
VijayanB pushed a commit that referenced this pull request Aug 6, 2021
* Add new docker building scripts for logstash

Signed-off-by: Peter Zhu <[email protected]>

* Move build related vars to the top

Signed-off-by: Peter Zhu <[email protected]>

* Tweak and improve the docker script comments

Signed-off-by: Peter Zhu <[email protected]>

* Resolve gem building incorrectly due to move of spec files

Signed-off-by: Peter Zhu <[email protected]>
@VijayanB VijayanB added the Infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. label Aug 6, 2021
VijayanB pushed a commit that referenced this pull request Aug 6, 2021
* Add new docker building scripts for logstash

Signed-off-by: Peter Zhu <[email protected]>

* Move build related vars to the top

Signed-off-by: Peter Zhu <[email protected]>

* Tweak and improve the docker script comments

Signed-off-by: Peter Zhu <[email protected]>

* Resolve gem building incorrectly due to move of spec files

Signed-off-by: Peter Zhu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants