Create docker files for build #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmazanec15
reviewed
Jun 28, 2021
| @@ -0,0 +1,21 @@ | |||
| #!/bin/bash | |||
|
|
|||
| # This is intended to be run the plugin's root directory. `dockerfiles/run.sh` | |||
Member
Author
There was a problem hiding this comment.
It is like build from source, here, instead of running in local, it will be executed inside the docker. I am planning to update the Developer guide to include this as well. Also, will use the same script without "docker-compose up" to publish the image to docker hub as well.
jmazanec15
approved these changes
Jul 2, 2021
VijayanB
force-pushed
the
docker-build
branch
5 times, most recently
from
50a8d9a to
2d17e0c
Compare
Added script to build docker image based on host's architecture. Supports only arm64 and x86_64, download corresponding base image and build. Signed-off-by: Vijayan Balasubramanian <[email protected]>
Include release drafts similar to other plugins. Signed-off-by: Vijayan Balasubramanian <[email protected]>
Since openseach supports only version 7, remove irrelevant warning message. Signed-off-by: Vijayan Balasubramanian <[email protected]>
jmazanec15
approved these changes
Jul 8, 2021
VijayanB
added
the
Infrastructure
This was referenced Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vijayan Balasubramanian [email protected]
Description
Added script to build docker image.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.