Use absolute path for template endpoint #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @VijayanB and @jmazanec15 could we get a review of this? Just wanted to see if there was any feedback you had or if it could be merged in. |
Signed-off-by: Stu Tomlinson <[email protected]>
Member
|
@dtaivpp Sure. Will get to it by EOD. |
Member
|
Looks like CI is failing for different reason. Will look into it first. |
Member
|
@nosnilmot I fixed CI issue. Can you rebase your change? Thanks. |
VijayanB
approved these changes
Jun 15, 2022
Member
VijayanB
left a comment
VijayanB
left a comment
There was a problem hiding this comment.
LGTM. Thanks for contribution.
Member
|
@dblock Can you take a look at this PR? Thanks |
VachaShah
approved these changes
Jun 15, 2022
Contributor
VachaShah
left a comment
VachaShah
left a comment
There was a problem hiding this comment.
Thank you @nosnilmot for this fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use absolute path for template endpoint ('/_template' instead of '_template')
Issues Resolved
Fixes #124
Fixes #144
Resolves this error installing template:
[2022-06-08T10:02:44,587][ERROR][logstash.outputs.opensearch][devicelogs_http_input] Failed to install template {:message=>"bad component(expected absolute path component): _template/<template name>", :exception=>URI::InvalidComponentError, ...Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.