Add dependency to opensearch-ruby #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VijayanB
force-pushed
the
update-opensearch-ruby
branch
4 times, most recently
from
d910951 to
7a7cada
Compare
jmazanec15
reviewed
Dec 7, 2021
|
|
||
| subject.multi_receive([LogStash::Event.new("my_id" => id, "my_action" => "delete", "message" => "foo", "my_version" => 100)]) | ||
| expect { es.get(:index => 'logstash-delete', :type => doc_type, :id => id, :refresh => true) }.to raise_error(Elasticsearch::Transport::Transport::Errors::NotFound) | ||
| expect { es.get(:index => 'logstash-delete', :type => doc_type, :id => id, :refresh => true) }.to raise_error(OpenSearch::Transport::Transport::Errors::NotFound) |
There was a problem hiding this comment.
Found some more instance where variable name is not renamed to opensearch. I updated it too.
Use OpenSearch::Client instead of Elasticsearch. Update all reference from Elasticsearch in spec to OpenSearch since opensearch-ruby is released. Signed-off-by: Vijayan Balasubramanian <[email protected]>
Update CI to test last two minor release. Signed-off-by: Vijayan Balasubramanian <[email protected]>
VijayanB
force-pushed
the
update-opensearch-ruby
branch
2 times, most recently
from
054b021 to
7c580d3
Compare
naveentatikonda
approved these changes
Dec 7, 2021
Signed-off-by: Vijayan Balasubramanian <[email protected]>
Update variable name to use opensearch Signed-off-by: Vijayan Balasubramanian <[email protected]>
VijayanB
force-pushed
the
update-opensearch-ruby
branch
from
7c580d3 to
b7202d8
Compare
VijayanB
added
1.2.0
jmazanec15
approved these changes
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
#55
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.