Replacing BaseNodeRequest by TransportRequest

[martin-gaievski]

Signed-off-by: Martin Gaievski [email protected]

Description

Remove usage of deprecated BaseNodeRequest (opensearch-project/OpenSearch#4702). For now no need to downport as core PR is for 3.0.0.

Check List

• All tests pass
• Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov-commenter]

Codecov Report

Merging #577 (874a562) into main (a2d84cc) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #577   +/-   ##
=========================================
  Coverage     83.65%   83.65%           
  Complexity     1028     1028           
=========================================
  Files           148      148           
  Lines          4233     4233           
  Branches        373      373           
=========================================
  Hits           3541     3541           
  Misses          516      516           
  Partials        176      176           

Impacted Files	Coverage Δ
...arch/knn/plugin/transport/KNNStatsNodeRequest.java	33.33% <ø> (ø)
...gin/transport/RemoveModelFromCacheNodeRequest.java	40.00% <ø> (ø)
...sport/TrainingJobRouteDecisionInfoNodeRequest.java	50.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[martin-gaievski]

issue with missing k-NN plugin in 2.4.0 is being worked on by core team. In a meantime I've checked locally with bwc from 2.3 to main and it's failing with exception

Caused by: java.security.AccessControlException: access denied ("java.lang.RuntimePermission" "accessClassInPackage.jdk.internal.org.objectweb.asm")
  [2022-10-13T22:20:29,694][WARN ][stderr                   ] [knnBwcCluster-rolling-0]   at java.base/java.security.AccessControlContext.checkPermission(AccessControlContext.java:472)
  [2022-10-13T22:20:29,695][WARN ][stderr                   ] [knnBwcCluster-rolling-0]   at java.base/java.security.AccessController.checkPermission(AccessController.java:897)
  [2022-10-13T22:20:29,695][WARN ][stderr                   ] [knnBwcCluster-rolling-0]   at java.base/java.lang.SecurityManager.checkPermission(SecurityManager.java:322)
  [2022-10-13T22:20:29,695][WARN ][stderr                   ] [knnBwcCluster-rolling-0]   at java.base/java.lang.SecurityManager.checkPackageAccess(SecurityManager.java:1238)
  [2022-10-13T22:20:29,696][WARN ][stderr                   ] [knnBwcCluster-rolling-0]   at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:174)
  [2022-10-13T22:20:29,696][WARN ][stderr                   ] [knnBwcCluster-rolling-0]   at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:522)
  [2022-10-13T22:20:29,696][WARN ][stderr                   ] [knnBwcCluster-rolling-0]   at Log4jHotPatch.asmVersion(Log4jHotPatch.java:71)
  [2022-10-13T22:20:29,696][WARN ][stderr                   ] [knnBwcCluster-rolling-0]   at Log4jHotPatch.agentmain(Log4jHotPatch.java:93)

Logged new issue for core - opensearch-project/OpenSearch#4788