Bumped gradle to 9.4.1 - #3308
Conversation
PR Code Analyzer ❗AI-powered 'Code-Diff-Analyzer' found issues on commit 00755f1.
The table above displays the top 10 most important findings. Pull Requests Author(s): Please update your Pull Request according to the report above. Repository Maintainer(s): You can Thanks. |
Signed-off-by: Andrew Klepchick <aklepchi@amazon.com>
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3308 +/- ##
============================================
- Coverage 83.48% 83.42% -0.07%
+ Complexity 4269 4265 -4
============================================
Files 450 450
Lines 15509 15509
Branches 2006 2006
============================================
- Hits 12948 12938 -10
- Misses 1768 1776 +8
- Partials 793 795 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* Bumped gradle to 9.4.1 and jacoco to 0.8.14 (#3308) Signed-off-by: Andrew Klepchick <aklepchi@amazon.com> * Use KNN1040ScalarQuantizedVectorsFormat for Faiss SQ flat format (#3302) The Faiss SQ format was using Lucene's Lucene104ScalarQuantizedVectorsFormat directly, which lacks the prefetch-enabled raw vector reader that KNN1040ScalarQuantizedVectorsFormat provides. This meant exact search rescoring was missing I/O prefetch during graph traversal. Changes: - Switch faissSqFlatFormat from Lucene104ScalarQuantizedVectorsFormat to KNN1040ScalarQuantizedVectorsFormat in Faiss1040ScalarQuantizedKnnVectorsFormat - Add @VisibleForTesting getFlatVectorsReader() to Faiss1040ScalarQuantizedKnnVectorsReader to replace reflection in tests - Add testGetRandomVectorScorer_returnsPrefetchableScorer in KNN1040ScalarQuantizedVectorsFormatTests verifying the scorer is PrefetchableRandomVectorScorer via a real write/read cycle - Replace reflection with getter in Faiss1040ScalarQuantizedKnnVectorsFormatTests.testFieldsReader_thenWrapsFlatReaderWithPrefetchSupport Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> * Allow minScore, maxDistance for 32x SQ index. Signed-off-by: Dooyong Kim <kdooyong@amazon.com> Pass compression and quantization config to RNN query builder. Signed-off-by: Dooyong Kim <kdooyong@amazon.com> Added RescoreRadialSearchQuery. Signed-off-by: Dooyong Kim <kdooyong@amazon.com> Wiring `RescoreRadialSearchQuery` wrapper in `RNNQueryFactory` Signed-off-by: Dooyong Kim <kdooyong@amazon.com> --------- Signed-off-by: Andrew Klepchick <aklepchi@amazon.com> Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> Signed-off-by: Dooyong Kim <kdooyong@amazon.com> Co-authored-by: Andrew Klepchick <aklepchi@amazon.com> Co-authored-by: Vijayan Balasubramanian <balasvij@amazon.com>
Signed-off-by: Andrew Klepchick <aklepchi@amazon.com>
* Rescoring after radial search on quantized index. [Task 1 - 4] (#3300) * Bumped gradle to 9.4.1 and jacoco to 0.8.14 (#3308) Signed-off-by: Andrew Klepchick <aklepchi@amazon.com> * Use KNN1040ScalarQuantizedVectorsFormat for Faiss SQ flat format (#3302) The Faiss SQ format was using Lucene's Lucene104ScalarQuantizedVectorsFormat directly, which lacks the prefetch-enabled raw vector reader that KNN1040ScalarQuantizedVectorsFormat provides. This meant exact search rescoring was missing I/O prefetch during graph traversal. Changes: - Switch faissSqFlatFormat from Lucene104ScalarQuantizedVectorsFormat to KNN1040ScalarQuantizedVectorsFormat in Faiss1040ScalarQuantizedKnnVectorsFormat - Add @VisibleForTesting getFlatVectorsReader() to Faiss1040ScalarQuantizedKnnVectorsReader to replace reflection in tests - Add testGetRandomVectorScorer_returnsPrefetchableScorer in KNN1040ScalarQuantizedVectorsFormatTests verifying the scorer is PrefetchableRandomVectorScorer via a real write/read cycle - Replace reflection with getter in Faiss1040ScalarQuantizedKnnVectorsFormatTests.testFieldsReader_thenWrapsFlatReaderWithPrefetchSupport Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> * Allow minScore, maxDistance for 32x SQ index. Signed-off-by: Dooyong Kim <kdooyong@amazon.com> Pass compression and quantization config to RNN query builder. Signed-off-by: Dooyong Kim <kdooyong@amazon.com> Added RescoreRadialSearchQuery. Signed-off-by: Dooyong Kim <kdooyong@amazon.com> Wiring `RescoreRadialSearchQuery` wrapper in `RNNQueryFactory` Signed-off-by: Dooyong Kim <kdooyong@amazon.com> --------- Signed-off-by: Andrew Klepchick <aklepchi@amazon.com> Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> Signed-off-by: Dooyong Kim <kdooyong@amazon.com> Co-authored-by: Andrew Klepchick <aklepchi@amazon.com> Co-authored-by: Vijayan Balasubramanian <balasvij@amazon.com> * Rescore radial search quantized complete (#3337) * Added exact search logic after radial. Signed-off-by: Dooyong Kim <kdooyong@amazon.com> * Adding 2nd rescoring after radial search on quantized index. Signed-off-by: Dooyong Kim <kdooyong@amazon.com> --------- Signed-off-by: Dooyong Kim <kdooyong@amazon.com> * Update changelog Signed-off-by: Dooyong Kim <kdooyong@amazon.com> --------- Signed-off-by: Andrew Klepchick <aklepchi@amazon.com> Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> Signed-off-by: Dooyong Kim <kdooyong@amazon.com> Co-authored-by: Andrew Klepchick <aklepchi@amazon.com> Co-authored-by: Vijayan Balasubramanian <balasvij@amazon.com>
* Enhance unit test coverage for 32x defaults Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> * Add BwC test coverage (#3329) Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> * Add base64 binary encoding as default format for knn_vector docvalue_fields (#3324) Signed-off-by: Navneet Verma <navneev@amazon.com> * Add issues write permission to untriaged label workflow (#3332) Signed-off-by: shreyah963 <shreyab963@gmail.com> * Fix score to radius conversion for IP with faiss (#3336) Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> Co-authored-by: Tejas Shah <shatejas@amazon.com> * Add ci.opensearch.org maven2 mirror to avoid throttling (#3345) Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> * [AUTO] Add release notes for 3.7.0 (#3342) Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> * Fix derived source for mixed-case vector fields (#3313) * Fix derived source for mixed-case vector fields Signed-off-by: Wonjae Lee <wonjae.lee@dremio.com> * Add BWC coverage for derived source field casing Signed-off-by: Wonjae Lee <wonjae.lee@dremio.com> * Add changelog entry for mixed-case derived source fix Signed-off-by: Wonjae Lee <wonjae.lee@dremio.com> * Handle case-insensitive conflicts by preferring vector field Signed-off-by: Wonjae Lee <wonjae.lee@dremio.com> * Avoid stream wrappers for derived field lookup Signed-off-by: Wonjae Lee <wonjae.lee@dremio.com> * Handle ambiguous case-insensitive matches without vector hints Signed-off-by: Wonjae Lee <wonjae.lee@dremio.com> * Update src/main/java/org/opensearch/knn/index/codec/KNN10010Codec/KNN10010DerivedSourceStoredFieldsFormat.java Co-authored-by: Tejas Shah <shatejas@amazon.com> Signed-off-by: Wonjae Lee <38933452+leewjae@users.noreply.github.com> * Apply spotless formatting for derived source field resolution Signed-off-by: Wonjae Lee <wonjae.lee@dremio.com> * Avoid guessing when case-insensitive matches lack vector hints Signed-off-by: Wonjae Lee <wonjae.lee@dremio.com> * Simplify case-insensitive derived field matching Signed-off-by: Wonjae Lee <wonjae.lee@dremio.com> * Trigger CI rerun for BWC investigation Signed-off-by: Wonjae Lee <wonjae.lee@dremio.com> * Add native engine field info coverage Signed-off-by: Wonjae Lee <wonjae.lee@dremio.com> --------- Signed-off-by: Wonjae Lee <wonjae.lee@dremio.com> Signed-off-by: Wonjae Lee <38933452+leewjae@users.noreply.github.com> Signed-off-by: Tejas Shah <shatejas@amazon.com> Co-authored-by: Tejas Shah <shatejas@amazon.com> Co-authored-by: Navneet Verma <navneev@amazon.com> * Fixes RescoreParser to pass the rescore flag (#3343) * Fixes RescoreParser to pass the rescore flag For multinode or coordinator-data node setup, rescore set to false is not passed through streams. This causes rescoring to execute even when its not disabled explicitly by user Signed-off-by: Tejas Shah <shatejas@amazon.com> * Updates Changelogs, improves code cov Signed-off-by: Tejas Shah <shatejas@amazon.com> * Makes the coordinator port dynamic Signed-off-by: Tejas Shah <shatejas@amazon.com> * Adds BWC test for mode and compression Signed-off-by: Tejas Shah <shatejas@amazon.com> * Does not create compressed indices before 2.18 Signed-off-by: Tejas Shah <shatejas@amazon.com> * Fixes bwc Signed-off-by: Tejas Shah <shatejas@amazon.com> --------- Signed-off-by: Tejas Shah <shatejas@amazon.com> * Merge rescore-radial-quantized feature branch to main (#3347) * Rescoring after radial search on quantized index. [Task 1 - 4] (#3300) * Bumped gradle to 9.4.1 and jacoco to 0.8.14 (#3308) Signed-off-by: Andrew Klepchick <aklepchi@amazon.com> * Use KNN1040ScalarQuantizedVectorsFormat for Faiss SQ flat format (#3302) The Faiss SQ format was using Lucene's Lucene104ScalarQuantizedVectorsFormat directly, which lacks the prefetch-enabled raw vector reader that KNN1040ScalarQuantizedVectorsFormat provides. This meant exact search rescoring was missing I/O prefetch during graph traversal. Changes: - Switch faissSqFlatFormat from Lucene104ScalarQuantizedVectorsFormat to KNN1040ScalarQuantizedVectorsFormat in Faiss1040ScalarQuantizedKnnVectorsFormat - Add @VisibleForTesting getFlatVectorsReader() to Faiss1040ScalarQuantizedKnnVectorsReader to replace reflection in tests - Add testGetRandomVectorScorer_returnsPrefetchableScorer in KNN1040ScalarQuantizedVectorsFormatTests verifying the scorer is PrefetchableRandomVectorScorer via a real write/read cycle - Replace reflection with getter in Faiss1040ScalarQuantizedKnnVectorsFormatTests.testFieldsReader_thenWrapsFlatReaderWithPrefetchSupport Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> * Allow minScore, maxDistance for 32x SQ index. Signed-off-by: Dooyong Kim <kdooyong@amazon.com> Pass compression and quantization config to RNN query builder. Signed-off-by: Dooyong Kim <kdooyong@amazon.com> Added RescoreRadialSearchQuery. Signed-off-by: Dooyong Kim <kdooyong@amazon.com> Wiring `RescoreRadialSearchQuery` wrapper in `RNNQueryFactory` Signed-off-by: Dooyong Kim <kdooyong@amazon.com> --------- Signed-off-by: Andrew Klepchick <aklepchi@amazon.com> Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> Signed-off-by: Dooyong Kim <kdooyong@amazon.com> Co-authored-by: Andrew Klepchick <aklepchi@amazon.com> Co-authored-by: Vijayan Balasubramanian <balasvij@amazon.com> * Rescore radial search quantized complete (#3337) * Added exact search logic after radial. Signed-off-by: Dooyong Kim <kdooyong@amazon.com> * Adding 2nd rescoring after radial search on quantized index. Signed-off-by: Dooyong Kim <kdooyong@amazon.com> --------- Signed-off-by: Dooyong Kim <kdooyong@amazon.com> * Update changelog Signed-off-by: Dooyong Kim <kdooyong@amazon.com> --------- Signed-off-by: Andrew Klepchick <aklepchi@amazon.com> Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> Signed-off-by: Dooyong Kim <kdooyong@amazon.com> Co-authored-by: Andrew Klepchick <aklepchi@amazon.com> Co-authored-by: Vijayan Balasubramanian <balasvij@amazon.com> * Add support for binary and byte field support in doc_values (#3340) Signed-off-by: Navneet Verma <navneev@amazon.com> * Pin GitHub Actions to commit SHAs (#3339) Signed-off-by: Divya Madala <divyaasm@amazon.com> Co-authored-by: Tejas Shah <shatejas@amazon.com> * Turn off ACORN for MOS (#3346) Signed-off-by: Andrew Klepchick <aklepchi@amazon.com> * Add base64 encoded vector indexing support for knn_vector fields (#3350) Vectors can now be indexed as base64-encoded strings in addition to JSON arrays. Float vectors use little-endian byte encoding (symmetric with the doc_values binary output format), while byte/binary vectors use raw byte encoding. This enables efficient bulk ingestion pipelines that avoid JSON array serialization overhead. Signed-off-by: Navneet Verma <navneev@amazon.com> * Made MemoryOptimizedSearchWarmup skip MemoryOptimizedSearchOldIndicesNotSupportedException. (#3344) Signed-off-by: Dooyong Kim <kdooyong@amazon.com> Signed-off-by: Doo Yong Kim <kdooyong@amazon.com> * Integrated proper ef_search functionality into MOS and Lucene with oversample_factor (#3331) * Check to see if Lucene's search budget has exhausted when deciding to exact search (#3354) * Update opensearch-build workflow references from commit SHA to main (#3363) Signed-off-by: Divya Madala <divyaasm@amazon.com> * Pinned the commit for tj-actions/changed-files for version v47.0.0 (#3367) Signed-off-by: Navneet Verma <navneev@amazon.com> --------- Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> Signed-off-by: Navneet Verma <navneev@amazon.com> Signed-off-by: shreyah963 <shreyab963@gmail.com> Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Signed-off-by: Wonjae Lee <wonjae.lee@dremio.com> Signed-off-by: Wonjae Lee <38933452+leewjae@users.noreply.github.com> Signed-off-by: Tejas Shah <shatejas@amazon.com> Signed-off-by: Andrew Klepchick <aklepchi@amazon.com> Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> Signed-off-by: Dooyong Kim <kdooyong@amazon.com> Signed-off-by: Divya Madala <divyaasm@amazon.com> Signed-off-by: Doo Yong Kim <kdooyong@amazon.com> Co-authored-by: Navneet Verma <navneev@amazon.com> Co-authored-by: Shreya Bhatta <shreyab963@gmail.com> Co-authored-by: Tejas Shah <shatejas@amazon.com> Co-authored-by: Sayali Gaikawad <gaiksaya@amazon.com> Co-authored-by: opensearch-ci <83309141+opensearch-ci-bot@users.noreply.github.com> Co-authored-by: Wonjae Lee <38933452+leewjae@users.noreply.github.com> Co-authored-by: Doo Yong Kim <kdooyong@amazon.com> Co-authored-by: Andrew Klepchick <aklepchi@amazon.com> Co-authored-by: Vijayan Balasubramanian <balasvij@amazon.com> Co-authored-by: Divya Madala <113469545+Divyaasm@users.noreply.github.com>
Description
Updates the Gradle wrapper from 9.2.0 to 9.4.1 to align with core OpenSearch, which moved to 9.4.1 in opensearch-project/OpenSearch#21153 as well as bumping jacoco from 0.8.13 to 0.8.14. Keeping the k-NN plugin's Gradle version in sync with core avoids build-tool drift and ensures compatibility with core's build-tools conventions.
Changes:
gradle/wrapper/gradle-wrapper.properties— bumpeddistributionUrltogradle-9.4.1-all.zipand updateddistributionSha256Sumto the official checksum.gradle/wrapper/gradle-wrapper.jar— replaced with the wrapper jar from core OpenSearch (SHAf8e1ee3125fe0768e9a76ee977ac089eb657005e).Verified by running
./gradlew compileJavaand./gradlew spotlessApplylocally — both pass on Gradle 9.4.1 with JDK 25.Related Issues
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.