[Backport 1.x] [CODE STYLE] Switch checkstyle to spotless#298
Merged
jmazanec15 merged 2 commits into1.xfrom Feb 18, 2022
Merged
[Backport 1.x] [CODE STYLE] Switch checkstyle to spotless#298jmazanec15 merged 2 commits into1.xfrom
jmazanec15 merged 2 commits into1.xfrom
Conversation
Switches checkstyle functionality to spotless. Sets ratchetFrom to origin/main. This will mean it will only fail on files recently changed. Pull formatting from OpenSearch. Signed-off-by: John Mazanec <jmazane@amazon.com> (cherry picked from commit 0db9b2e)
Signed-off-by: John Mazanec <jmazane@amazon.com>
Codecov Report
@@ Coverage Diff @@
## 1.x #298 +/- ##
=========================================
Coverage 83.38% 83.38%
Complexity 885 885
=========================================
Files 127 127
Lines 3834 3834
Branches 361 361
=========================================
Hits 3197 3197
Misses 475 475
Partials 162 162
Continue to review full report at Codecov.
|
jmazanec15
approved these changes
Feb 18, 2022
martin-gaievski
approved these changes
Feb 18, 2022
martin-gaievski
pushed a commit
to martin-gaievski/k-NN
that referenced
this pull request
Mar 7, 2022
…-project#298) Switches checkstyle functionality to spotless. Sets ratchetFrom to origin/1.x. This will mean it will only fail on files recently changed. Pull formatting from OpenSearch. Signed-off-by: John Mazanec <jmazane@amazon.com> (cherry picked from commit 0db9b2e)
martin-gaievski
pushed a commit
to martin-gaievski/k-NN
that referenced
this pull request
Mar 7, 2022
…-project#298) Switches checkstyle functionality to spotless. Sets ratchetFrom to origin/1.x. This will mean it will only fail on files recently changed. Pull formatting from OpenSearch. Signed-off-by: John Mazanec <jmazane@amazon.com> (cherry picked from commit 0db9b2e) Signed-off-by: Martin Gaievski <gaievski@amazon.com>
martin-gaievski
pushed a commit
to martin-gaievski/k-NN
that referenced
this pull request
Mar 31, 2022
…-project#298) Switches checkstyle functionality to spotless. Sets ratchetFrom to origin/1.x. This will mean it will only fail on files recently changed. Pull formatting from OpenSearch. Signed-off-by: John Mazanec <jmazane@amazon.com> (cherry picked from commit 0db9b2e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 0db9b2e from #297