Skip to content

Bump JDK to 24, gradle to 8.14 #2792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 16, 2025
Merged

Bump JDK to 24, gradle to 8.14 #2792

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
dedbedf
Bump JDK to 24, gradle to 8.14
finnroblin Jul 14, 2025
2937c7f
bump lombok to 8.14, add changelog entry
finnroblin Jul 14, 2025
c480ce5
bump jacoco version
finnroblin Jul 14, 2025
6113dd5
Merge branch 'main' into jdk-24-bump
finnroblin Jul 14, 2025
8104992
remove java 24 from bwc to avoid getTotalPhysicalMemorySize/getTotalM…
finnroblin Jul 14, 2025
a71d605
switch from deprecate java SM to opensearch SM in RemoteIndexHTTPClient
finnroblin Jul 14, 2025
1851c62
add accessUnixDomainSocket to fix windows CI
finnroblin Jul 15, 2025
af11361
changelog change to rerun CI
finnroblin Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
Build-k-NN-Linux:
strategy:
matrix:
java: [21, 23]
java: [21, 24]

env:
CC: gcc10-gcc
Expand Down Expand Up @@ -106,7 +106,7 @@ jobs:
Build-k-NN-MacOS:
strategy:
matrix:
java: [21, 23]
java: [21, 24]

name: Build and Test k-NN Plugin on MacOS
needs: Get-CI-Image-Tag
Expand Down Expand Up @@ -149,7 +149,7 @@ jobs:
Build-k-NN-Windows:
strategy:
matrix:
java: [21, 23]
java: [21, 24]

name: Build and Test k-NN Plugin on Windows
needs: Get-CI-Image-Tag
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test_security.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
integ-test-with-security-linux:
strategy:
matrix:
java: [21]
java: [21, 24]
env:
CC: gcc10-gcc
CXX: gcc10-g++
Expand Down
5 changes: 4 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,10 @@ All notable changes to this project are documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). See the [CONTRIBUTING guide](./CONTRIBUTING.md#Changelog) for instructions on how to add changelog entries.

## [Unreleased 3.2](https://github.com/opensearch-project/k-NN/compare/main...HEAD)
### Infrastructure
* Bump JDK version to 24, gradle to 8.14 [#2792](https://github.com/opensearch-project/k-NN/pull/2792)

### Enhancements
* Add random rotation feature to binary encoder for improving recall on certain datasets [#2718](https://github.com/opensearch-project/k-NN/pull/2718)
* Asymmetric Distance Computation for binary quantized faiss indices [#2733](https://github.com/opensearch-project/k-NN/pull/2733)
* [BUGFIX] [Remote Vector Index Build] Don't fall back to CPU on terminal failures [#2773](https://github.com/opensearch-project/k-NN/pull/2773)
* [BUGFIX] [Remote Vector Index Build] Don't fall back to CPU on terminal failures [#2773](https://github.com/opensearch-project/k-NN/pull/2773)
2 changes: 1 addition & 1 deletion build-tools/knnplugin-coverage.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
apply plugin: 'jacoco'

jacoco {
toolVersion = "0.8.12"
toolVersion = "0.8.13"
}

/**
Expand Down
2 changes: 1 addition & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ plugins {
id 'java-test-fixtures'
id 'idea'
id "com.diffplug.spotless" version "6.25.0" apply false
id 'io.freefair.lombok' version '8.4'
id 'io.freefair.lombok' version '8.14'
id "de.undercouch.download" version "5.3.0"
}

Expand Down
4 changes: 2 additions & 2 deletions gradle/wrapper/gradle-wrapper.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@

distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionSha256Sum=fba8464465835e74f7270bbf43d6d8a8d7709ab0a43ce1aa3323f73e9aa0c612
distributionUrl=https\://services.gradle.org/distributions/gradle-8.13-all.zip
distributionSha256Sum=efe9a3d147d948d7528a9887fa35abcf24ca1a43ad06439996490f77569b02d1
distributionUrl=https\://services.gradle.org/distributions/gradle-8.14-all.zip
networkTimeout=10000
validateDistributionUrl=true
zipStoreBase=GRADLE_USER_HOME
Expand Down
2 changes: 1 addition & 1 deletion remote-index-build-client/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ plugins {
id 'java'
id 'java-library'
id 'jacoco'
id "io.freefair.lombok"
id "io.freefair.lombok" version "8.14"
id 'com.diffplug.spotless' version '6.25.0'
id 'opensearch.build'
id 'opensearch.java-agent'
Expand Down
1 change: 1 addition & 0 deletions src/main/plugin-metadata/plugin-security.policy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ grant {
permission java.lang.RuntimePermission "loadLibrary.opensearchknn_faiss_avx512";
permission java.lang.RuntimePermission "loadLibrary.opensearchknn_faiss_avx512_spr";
permission java.net.SocketPermission "*", "connect,resolve";
permission java.net.NetPermission "accessUnixDomainSocket";
Copy link
Member

@naveentatikonda naveentatikonda Jul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we adding this?

Copy link
Contributor Author

@finnroblin finnroblin Jul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need this permission for remote index build client on windows. Otherwise it will fail due to the OS security manager. OS core needed to add it to their transport plugins which use similar mechanisms to remote index build client.

Copy link
Member

@naveentatikonda naveentatikonda Jul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense. Thanks!

permission java.lang.RuntimePermission "accessDeclaredMembers";
permission java.io.FilePermission "/proc/cpuinfo", "read";
};
Loading