Set default space type to L2 to support bwc#267
Merged
jmazanec15 merged 1 commit intoopensearch-project:mainfrom Jan 26, 2022
Merged
Set default space type to L2 to support bwc#267jmazanec15 merged 1 commit intoopensearch-project:mainfrom
jmazanec15 merged 1 commit intoopensearch-project:mainfrom
Conversation
This change adds L2 space type fall back during query. This prevents backwards compatibility issues for clusters upgrading from ES 7.1 and 7.4. In those versions, space type was not introduced as a field attribute yet. Signed-off-by: John Mazanec <jmazane@amazon.com>
jmazanec15
force-pushed
the
fix-spacetype-check
branch
from
9884724 to
d6268dc
Compare
VijayanB
reviewed
Jan 24, 2022
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #267 +/- ##
=========================================
Coverage 83.37% 83.38%
Complexity 884 884
=========================================
Files 127 127
Lines 3832 3833 +1
Branches 361 361
=========================================
+ Hits 3195 3196 +1
Misses 475 475
Partials 162 162 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
junqiu-lei
approved these changes
Jan 24, 2022
5 tasks
martin-gaievski
pushed a commit
to martin-gaievski/k-NN
that referenced
this pull request
Mar 7, 2022
This change adds L2 space type fall back during query. This prevents backwards compatibility issues for clusters upgrading from ES 7.1 and 7.4. In those versions, space type was not introduced as a field attribute yet. Signed-off-by: John Mazanec <jmazane@amazon.com>
martin-gaievski
pushed a commit
to martin-gaievski/k-NN
that referenced
this pull request
Mar 7, 2022
This change adds L2 space type fall back during query. This prevents backwards compatibility issues for clusters upgrading from ES 7.1 and 7.4. In those versions, space type was not introduced as a field attribute yet. Signed-off-by: John Mazanec <jmazane@amazon.com> Signed-off-by: Martin Gaievski <gaievski@amazon.com>
martin-gaievski
pushed a commit
to martin-gaievski/k-NN
that referenced
this pull request
Mar 30, 2022
This change adds L2 space type fall back during query. This prevents backwards compatibility issues for clusters upgrading from ES 7.1 and 7.4. In those versions, space type was not introduced as a field attribute yet. Signed-off-by: John Mazanec <jmazane@amazon.com>
jingqimao77-spec
pushed a commit
to jingqimao77-spec/k-NN
that referenced
this pull request
Mar 15, 2026
This change adds L2 space type fall back during query. This prevents backwards compatibility issues for clusters upgrading from ES 7.1 and 7.4. In those versions, space type was not introduced as a field attribute yet. Signed-off-by: John Mazanec <jmazane@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change adds L2 space type fall back during query. This prevents backwards compatibility issues for clusters upgrading from ES 7.1 and 7.4. In those versions, space type was not introduced as a field attribute yet.
Issues Resolved
#255
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.