Add Recall Tests#251
Merged
naveentatikonda merged 2 commits intoopensearch-project:mainfrom Jan 15, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #251 +/- ##
============================================
+ Coverage 83.22% 83.28% +0.05%
- Complexity 865 866 +1
============================================
Files 123 123
Lines 3780 3780
Branches 359 359
============================================
+ Hits 3146 3148 +2
+ Misses 473 471 -2
Partials 161 161
Continue to review full report at Codecov.
|
jmazanec15
reviewed
Jan 7, 2022
naveentatikonda
force-pushed
the
add_recall_tests
branch
from
d863b75 to
a21a8f3
Compare
VijayanB
reviewed
Jan 7, 2022
naveentatikonda
force-pushed
the
add_recall_tests
branch
3 times, most recently
from
bfb19bd to
28258ff
Compare
naveentatikonda
requested review from
VijayanB,
jmazanec15 and
martin-gaievski
martin-gaievski
requested changes
Jan 12, 2022
naveentatikonda
force-pushed
the
add_recall_tests
branch
from
28258ff to
7725e7b
Compare
VijayanB
reviewed
Jan 12, 2022
VijayanB
reviewed
Jan 12, 2022
VijayanB
reviewed
Jan 12, 2022
VijayanB
reviewed
Jan 12, 2022
naveentatikonda
force-pushed
the
add_recall_tests
branch
from
7725e7b to
aaa06fc
Compare
martin-gaievski
previously approved these changes
Jan 12, 2022
jmazanec15
reviewed
Jan 12, 2022
Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
naveentatikonda
force-pushed
the
add_recall_tests
branch
2 times, most recently
from
d6bfe48 to
7a97820
Compare
martin-gaievski
previously approved these changes
Jan 13, 2022
jmazanec15
reviewed
Jan 14, 2022
Member
jmazanec15
left a comment
jmazanec15
left a comment
There was a problem hiding this comment.
There seems to be some duplicate code in RecallIT and KNNBackwardsCompatibilityIT. Why is this necessary?
Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
naveentatikonda
force-pushed
the
add_recall_tests
branch
from
7a97820 to
653ddbd
Compare
martin-gaievski
approved these changes
Jan 14, 2022
jmazanec15
approved these changes
Jan 14, 2022
martin-gaievski
pushed a commit
to martin-gaievski/k-NN
that referenced
this pull request
Mar 7, 2022
* Add Recall Tests Signed-off-by: Naveen Tatikonda <navtat@amazon.com> * Calculate Recall using document ids and other minor changes Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
martin-gaievski
pushed a commit
to martin-gaievski/k-NN
that referenced
this pull request
Mar 7, 2022
* Add Recall Tests Signed-off-by: Naveen Tatikonda <navtat@amazon.com> * Calculate Recall using document ids and other minor changes Signed-off-by: Naveen Tatikonda <navtat@amazon.com> Signed-off-by: Martin Gaievski <gaievski@amazon.com>
martin-gaievski
pushed a commit
to martin-gaievski/k-NN
that referenced
this pull request
Mar 30, 2022
* Add Recall Tests Signed-off-by: Naveen Tatikonda <navtat@amazon.com> * Calculate Recall using document ids and other minor changes Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
jingqimao77-spec
pushed a commit
to jingqimao77-spec/k-NN
that referenced
this pull request
Mar 15, 2026
* Add Recall Tests Signed-off-by: Naveen Tatikonda <navtat@amazon.com> * Calculate Recall using document ids and other minor changes Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Naveen Tatikonda navtat@amazon.com
Description
Adding recall tests to integration tests and backward compatibility tests. This includes two separate tests where the vectors are generated using some standard function in one test and randomly generated vectors in other test. 'l2' is the spaceType used to measure distance between two points.
Issues Resolved
#250
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.