[Manual backport 2.x] Backport cache maintenance PR and its recent fix#2390
Merged
shatejas merged 2 commits intoopensearch-project:2.xfrom Jan 15, 2025
Merged
Conversation
…rch-project#2308) Signed-off-by: owenhalpert <ohalpert@gmail.com>
Signed-off-by: owenhalpert <ohalpert@gmail.com>
owenhalpert
changed the title
5 tasks
owenhalpert
requested review from
0ctopus13prime,
VijayanB,
heemin32,
jmazanec15,
junqiu-lei,
luyuncheng,
martin-gaievski,
naveentatikonda,
navneet1v,
ryanbogan,
shatejas and
vamshin
as code owners
jmazanec15
approved these changes
Jan 14, 2025
kotwanikunal
approved these changes
Jan 14, 2025
shatejas
approved these changes
Jan 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The auto-created backport PR #2383 failed and revealed an issue that needs to make it into mainline as well. Because only the backport PR failed, the original commit was not merged into the backport branch, so this PR manually backports the commits of both PRs by cherry-picking both onto the checked out 2.x branch. (#2387 and #2308).
Related Issues
#2308 (original cache maintenance PR)
#2387 (new fix to the above)
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.