Add spaceType as a top level parameter while creating vector field.#2044
Merged
navneet1v merged 3 commits intoopensearch-project:mainfrom Sep 5, 2024
Merged
Add spaceType as a top level parameter while creating vector field.#2044navneet1v merged 3 commits intoopensearch-project:mainfrom
navneet1v merged 3 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Navneet Verma <navneev@amazon.com>
Signed-off-by: John Mazanec <jmazane@amazon.com>
Signed-off-by: John Mazanec <jmazane@amazon.com>
naveentatikonda
approved these changes
Sep 5, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 5, 2024
…2044) * Add spaceType as a top level parameter while creating vector field. Signed-off-by: Navneet Verma <navneev@amazon.com> * fix release notes Signed-off-by: John Mazanec <jmazane@amazon.com> * Remove commented out code Signed-off-by: John Mazanec <jmazane@amazon.com> --------- Signed-off-by: Navneet Verma <navneev@amazon.com> Signed-off-by: John Mazanec <jmazane@amazon.com> Co-authored-by: John Mazanec <jmazane@amazon.com> (cherry picked from commit cb9ba71)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 5, 2024
…2044) * Add spaceType as a top level parameter while creating vector field. Signed-off-by: Navneet Verma <navneev@amazon.com> * fix release notes Signed-off-by: John Mazanec <jmazane@amazon.com> * Remove commented out code Signed-off-by: John Mazanec <jmazane@amazon.com> --------- Signed-off-by: Navneet Verma <navneev@amazon.com> Signed-off-by: John Mazanec <jmazane@amazon.com> Co-authored-by: John Mazanec <jmazane@amazon.com> (cherry picked from commit cb9ba71)
naveentatikonda
pushed a commit
that referenced
this pull request
Sep 5, 2024
…2044) (#2050) * Add spaceType as a top level parameter while creating vector field. Signed-off-by: Navneet Verma <navneev@amazon.com> * fix release notes Signed-off-by: John Mazanec <jmazane@amazon.com> * Remove commented out code Signed-off-by: John Mazanec <jmazane@amazon.com> --------- Signed-off-by: Navneet Verma <navneev@amazon.com> Signed-off-by: John Mazanec <jmazane@amazon.com> Co-authored-by: John Mazanec <jmazane@amazon.com> (cherry picked from commit cb9ba71) Co-authored-by: Navneet Verma <navneev@amazon.com>
ryanbogan
pushed a commit
that referenced
this pull request
Sep 5, 2024
…2044) (#2049) * Add spaceType as a top level parameter while creating vector field. Signed-off-by: Navneet Verma <navneev@amazon.com> * fix release notes Signed-off-by: John Mazanec <jmazane@amazon.com> * Remove commented out code Signed-off-by: John Mazanec <jmazane@amazon.com> --------- Signed-off-by: Navneet Verma <navneev@amazon.com> Signed-off-by: John Mazanec <jmazane@amazon.com> Co-authored-by: John Mazanec <jmazane@amazon.com> (cherry picked from commit cb9ba71) Co-authored-by: Navneet Verma <navneev@amazon.com>
akashsha1
pushed a commit
to akashsha1/k-NN
that referenced
this pull request
Sep 16, 2024
…pensearch-project#2044) * Add spaceType as a top level parameter while creating vector field. Signed-off-by: Navneet Verma <navneev@amazon.com> * fix release notes Signed-off-by: John Mazanec <jmazane@amazon.com> * Remove commented out code Signed-off-by: John Mazanec <jmazane@amazon.com> --------- Signed-off-by: Navneet Verma <navneev@amazon.com> Signed-off-by: John Mazanec <jmazane@amazon.com> Co-authored-by: John Mazanec <jmazane@amazon.com> Signed-off-by: Akash Shankaran <akash.shankaran@intel.com>
jingqimao77-spec
pushed a commit
to jingqimao77-spec/k-NN
that referenced
this pull request
Mar 15, 2026
…pensearch-project#2044) * Add spaceType as a top level parameter while creating vector field. Signed-off-by: Navneet Verma <navneev@amazon.com> * fix release notes Signed-off-by: John Mazanec <jmazane@amazon.com> * Remove commented out code Signed-off-by: John Mazanec <jmazane@amazon.com> --------- Signed-off-by: Navneet Verma <navneev@amazon.com> Signed-off-by: John Mazanec <jmazane@amazon.com> Co-authored-by: John Mazanec <jmazane@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add spaceType as a top level parameter while creating vector field. With this change a user can change the spaceType for the vector field without defining the
methodparameter in the mapping. With this change Disk based vector search OOB experience is improved.Things to be added:
Tests will be added in followup PRs
How testing is done:
I have performed manual testing by running following create index request.
Success
Success and hits the legacy method and use the innerproduct space type
Related Issues
#1949
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.