[Backport 2.x] Introduce mode and compression param resolution#2042
Merged
jmazanec15 merged 2 commits into2.xfrom Sep 5, 2024
Merged
[Backport 2.x] Introduce mode and compression param resolution#2042jmazanec15 merged 2 commits into2.xfrom
jmazanec15 merged 2 commits into2.xfrom
Conversation
* Introduce mode and compression param resolution Adds mode and compression based parameter resolution. With this, if a user specifies the mode and/or compression params, we will create a default configuration with the aim of meeting those hints. Currently, it does not contain support for overriding any of the parameters. This will be taken in a future commit. Signed-off-by: John Mazanec <jmazane@amazon.com> * Modify reader changes Signed-off-by: John Mazanec <jmazane@amazon.com> --------- Signed-off-by: John Mazanec <jmazane@amazon.com> (cherry picked from commit ef4922a)
opensearch-trigger-bot
bot
requested review from
VijayanB,
heemin32,
jmazanec15,
junqiu-lei,
luyuncheng,
martin-gaievski,
naveentatikonda,
navneet1v,
ryanbogan and
vamshin
as code owners
Signed-off-by: John Mazanec <jmazane@amazon.com>
jmazanec15
approved these changes
Sep 5, 2024
naveentatikonda
approved these changes
Sep 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport ef4922a from #2034