Skip to content

Fixing the format name for NativeEngines990KnnVectorsFormat #2025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
navneet1v merged 1 commit into from
Sep 4, 2024
Merged

Fixing the format name for NativeEngines990KnnVectorsFormat #2025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ain/java/org/opensearch/knn/index/codec/KNN990Codec/NativeEngines990KnnVectorsFormat.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
public class NativeEngines990KnnVectorsFormat extends KnnVectorsFormat {
/** The format for storing, reading, merging vectors on disk */
private static FlatVectorsFormat flatVectorsFormat;
private static final String FORMAT_NAME = "NativeEngines99KnnVectorsFormat";
private static final String FORMAT_NAME = "NativeEngines990KnnVectorsFormat";

public NativeEngines990KnnVectorsFormat() {
super(FORMAT_NAME);
Expand Down
11 changes: 11 additions & 0 deletions ...ava/org/opensearch/knn/index/codec/KNN990Codec/NativeEngines990KnnVectorsFormatTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
import lombok.SneakyThrows;
import lombok.extern.log4j.Log4j2;
import org.apache.lucene.codecs.Codec;
import org.apache.lucene.codecs.hnsw.FlatVectorScorerUtil;
import org.apache.lucene.codecs.hnsw.FlatVectorsReader;
import org.apache.lucene.codecs.hnsw.FlatVectorsWriter;
import org.apache.lucene.codecs.lucene99.Lucene99FlatVectorsFormat;
Expand Down Expand Up @@ -226,6 +227,16 @@ public void testNativeEngineVectorFormat_whenBinaryQuantizationApplied_thenSucce
indexReader.close();
}

public void testFormatName_withValidInput_thenSuccess() {
final String validFormatName = "NativeEngines990KnnVectorsFormat";
Assert.assertEquals(validFormatName, new NativeEngines990KnnVectorsFormat().getName());
Assert.assertEquals(
validFormatName,
new NativeEngines990KnnVectorsFormat(new Lucene99FlatVectorsFormat(FlatVectorScorerUtil.getLucene99FlatVectorsScorer()))
.getName()
);
}

private List<String> getFilesFromSegment(Directory dir, String fileFormat) throws IOException {
return Arrays.stream(dir.listAll()).filter(x -> x.contains(fileFormat)).collect(Collectors.toList());
}
Expand Down