Replace search sorted by _id to _seq_no for query getting job metadata on sweep - #896
Merged
Merged
Conversation
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
…a on sweep Signed-off-by: Craig Perkins <cwperx@amazon.com>
cwperks
requested review from
dbwiddis,
joshpalis,
kaituo,
prudhvigodithi,
saratvemulapalli and
vibrantvarun
as code owners
March 24, 2026 19:56
Codecov Report❌ Patch coverage is
❌ Your project check has failed because the head coverage (70.48%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #896 +/- ##
==========================================
+ Coverage 70.29% 70.48% +0.18%
==========================================
Files 42 42
Lines 2057 2060 +3
Branches 165 164 -1
==========================================
+ Hits 1446 1452 +6
+ Misses 503 496 -7
- Partials 108 112 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
66 tasks
Member
|
@prudhvigodithi @Swiddis @kaituo Would you please approve this quick PR? Thanks! |
kaituo
approved these changes
Mar 24, 2026
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/job-scheduler/backport-2.19 2.19
# Navigate to the new working tree
pushd ../.worktrees/job-scheduler/backport-2.19
# Create a new branch
git switch --create backport/backport-896-to-2.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 014d31e4f92d1dfeb39d8cfec5218e409e29c4b2
# Push it to GitHub
git push --set-upstream origin backport/backport-896-to-2.19
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/job-scheduler/backport-2.19Then, create a pull request where the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the issue described in #892 by sorting on _seq_no instead of _id.
See related alerting PR: opensearch-project/alerting#2039
Related Issues
Resolves #892
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.