Skip to content

Backport: Update build.sh script to include optional platform param (#99)#102

Closed
gaiksaya wants to merge 1 commit intoopensearch-project:1.1from
gaiksaya:build-1.1
Closed

Backport: Update build.sh script to include optional platform param (#99)#102
gaiksaya wants to merge 1 commit intoopensearch-project:1.1from
gaiksaya:build-1.1

Conversation

@gaiksaya
Copy link
Copy Markdown
Member

@gaiksaya gaiksaya commented Nov 15, 2021

Signed-off-by: Sayali Gaikawad gaiksaya@amazon.com

Description

Backport PR: #99
Add optional platform param sent by build workflow. This param is optional in this script but will always be sent by the workflow.

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@gaiksaya
Copy link
Copy Markdown
Member Author

gaiksaya commented Nov 15, 2021

@dblock @peternied please review. Not sure what the link checker error is here. Ohh build failed too :(

@peternied
Copy link
Copy Markdown
Member

Why are we backporting this to 1.1?

@gaiksaya
Copy link
Copy Markdown
Member Author

gaiksaya commented Nov 16, 2021

Why are we backporting this to 1.1?

Because 1.1 branch is used to build these artifacts. Once we backport this we can delete the scripts from opensearch-build repo so that this script is executed.
Correct me if I am wrong @dblock

@peternied
Copy link
Copy Markdown
Member

peternied commented Nov 17, 2021

Why are we backporting this to 1.1?

Because 1.1 branch is used to build these artifacts. Once we backport this we can delete the scripts from opensearch-build repo so that this script is executed.

Correct me if I am wrong @dblock

I am uneasy with making changes to component branches that already released. This seems like a candidate for back comparability support inside of open search build

@gaiksaya gaiksaya changed the base branch from 1.1 to 1.2 November 17, 2021 04:18
@gaiksaya gaiksaya changed the base branch from 1.2 to 1.1 November 17, 2021 04:19
@gaiksaya
Copy link
Copy Markdown
Member Author

My bad, it should have been 1.2. Closing this PR

@gaiksaya gaiksaya closed this Nov 17, 2021
@gaiksaya gaiksaya deleted the build-1.1 branch November 17, 2021 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants