-
Notifications
You must be signed in to change notification settings - Fork 92
Fixing bug in transform API validation to support index patterns #1237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we have a test to cover this change?
Signed-off-by: Kshitij Tandon <[email protected]>
abb8b3c
to
bc26f9f
Compare
Signed-off-by: Kshitij Tandon <[email protected]>
Signed-off-by: Kshitij Tandon <[email protected]>
fa33bd5
Signed-off-by: Kshitij Tandon <[email protected]>
Signed-off-by: Kshitij Tandon <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing and adding an integration test 🙌
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/index-management-dashboards-plugin/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/index-management-dashboards-plugin/backport-2.x
# Create a new branch
git switch --create backport/backport-1237-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 bed34ddf5e709ba75c77412bb36231c0c953b1ca
# Push it to GitHub
git push --set-upstream origin backport/backport-1237-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/index-management-dashboards-plugin/backport-2.x Then, create a pull request where the |
…nsearch-project#1237) * Fixing bug in transform API validation Signed-off-by: Kshitij Tandon <[email protected]> * Adding test for creating transform job using wildcard Signed-off-by: Kshitij Tandon <[email protected]> * Retracting a change which was for testing only Signed-off-by: Kshitij Tandon <[email protected]> * Fixing an issue with the delete test of transform Signed-off-by: Kshitij Tandon <[email protected]> * Modifying transform test Signed-off-by: Kshitij Tandon <[email protected]> --------- Signed-off-by: Kshitij Tandon <[email protected]>
…x patterns (#1237) (#1241) * Fixing bug in transform API validation to support index patterns (#1237) * Fixing bug in transform API validation Signed-off-by: Kshitij Tandon <[email protected]> * Adding test for creating transform job using wildcard Signed-off-by: Kshitij Tandon <[email protected]> * Retracting a change which was for testing only Signed-off-by: Kshitij Tandon <[email protected]> * Fixing an issue with the delete test of transform Signed-off-by: Kshitij Tandon <[email protected]> * Modifying transform test Signed-off-by: Kshitij Tandon <[email protected]> --------- Signed-off-by: Kshitij Tandon <[email protected]> * Removing an unintended change while resolving conflict Signed-off-by: Kshitij Tandon <[email protected]> --------- Signed-off-by: Kshitij Tandon <[email protected]>
Description
Fixing #1224
Issues Resolved
Resolves #1224
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.