Skip to content

Conversation

@vagimeli
Copy link
Contributor

@vagimeli vagimeli commented Feb 1, 2024

Description

Updates gantt chart dashboards plugin link to GitHub

Issues Resolved

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli
Copy link
Contributor Author

vagimeli commented Feb 1, 2024

@hdhalter This updates the GitHub link to the gantt charts dashboards plugin. The PR is related to the dead link error on 1/31/2024.

@vagimeli vagimeli added the backport 2.11 PR: Backport label for 2.11 label Feb 1, 2024
@vagimeli vagimeli self-assigned this Feb 1, 2024
@vagimeli
Copy link
Contributor Author

vagimeli commented Feb 1, 2024

@joshuali925 Please verify the change to the GitHub link for gantt chart dashboards plugin. Is this the cross-reference we should use to guide users to the proper information. The doc team received a dead link error, so we need to update the documentation accordingly. Thank you.

@vagimeli vagimeli added Tech review PR: Tech review in progress Doc review PR: Doc review in progress labels Feb 1, 2024
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @vagimeli, the link is correct. it changed due to opensearch-project/dashboards-visualizations#321

| Custom Import Maps Dashboards | [dashboards-maps](https://github.com/opensearch-project/dashboards-maps) | 2.2.0 |
| Search Relevance Dashboards | [dashboards-search-relevance](https://github.com/opensearch-project/dashboards-search-relevance) | 2.4.0 |
| Gantt Chart Dashboards | [gantt-chart](https://github.com/opensearch-project/dashboards-visualizations/tree/main/gantt-chart) | 1.0.0 |
| Gantt Chart Dashboards | [gantt-chart](https://github.com/opensearch-project/dashboards-visualizations/tree/main) | 1.0.0 |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it might be better to remove the /tree/main to be consistent with other plugins, but shouldn't really matter

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli vagimeli merged commit 0835baa into main Feb 2, 2024
@vagimeli vagimeli deleted the update-link branch February 2, 2024 17:57
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 2, 2024
* Update gantt chart dashboards plugin link

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

* Update plugins.md

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

---------

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
(cherry picked from commit 0835baa)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vagimeli pushed a commit that referenced this pull request Feb 2, 2024
* Update gantt chart dashboards plugin link



* Update plugins.md



---------


(cherry picked from commit 0835baa)

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.11 PR: Backport label for 2.11 Doc review PR: Doc review in progress Tech review PR: Tech review in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants