Skip to content

update compatibility matrix and remove setting [issue 517]#558

Merged
alicejw1 merged 8 commits intoopensearch-project:mainfrom
alicejw1:517-override-main
May 23, 2022
Merged

update compatibility matrix and remove setting [issue 517]#558
alicejw1 merged 8 commits intoopensearch-project:mainfrom
alicejw1:517-override-main

Conversation

@alicejw1
Copy link
Contributor

@alicejw1 alicejw1 commented May 5, 2022 •
edited
Loading

Signed-off-by: alicejw alicejw@amazon.com

Description

Remove setting that was removed from OpenSearch 2.0.
we will not support this anymore for clients working with OpenSearch clusters 2.0 and up.

Issues Resolved

This PR closes this document issue:
517

Note: This other related issue will be handled in separate PR:
533

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

alicejw added 2 commits May 5, 2022 13:52
remove instances of setting that is no longer available in OS2.0
fff42db 
Signed-off-by: alicejw <alicejw@amazon.com>
add note to legacy clients matrix
31decfa 
Signed-off-by: alicejw <alicejw@amazon.com>
@alicejw1 alicejw1 requested review from Naarcha-AWS and elfisher May 5, 2022 21:31
@alicejw1 alicejw1 requested a review from a team as a code owner May 5, 2022 21:31
@alicejw1 alicejw1 self-assigned this May 5, 2022
update note for 2.0 incompatible with legacy clients
776c6fe 
Signed-off-by: alicejw <alicejw@amazon.com>
@alicejw1 alicejw1 marked this pull request as draft May 5, 2022 21:32
@alicejw1 alicejw1 linked an issue May 5, 2022 that may be closed by this pull request
[FEATURE] Update clients and tools compatibility matrix #533
Closed
@alicejw1 alicejw1 marked this pull request as ready for review May 9, 2022 21:53
@alicejw1 alicejw1 linked an issue May 10, 2022 that may be closed by this pull request
[Remove] Override main response feature for clients #517
Closed
@alicejw1
Copy link
Contributor Author

alicejw1 commented May 11, 2022

Note: The current updates/commits to remove the setting does satisfy the #517 issue.

The to-do item (list all compatibility issues per client) will satisfy the #533 issue.

so it's ok to send PR for review now and just wait to merge it until the updates are (committed to this PR) done for #533.

@alicejw1 alicejw1 removed a link to an issue May 16, 2022
[FEATURE] Update clients and tools compatibility matrix #533
Closed
for issue 517 override setting not supported for legacy clients in Op…
da027fb 
…enSearch version 2.0

Signed-off-by: alicejw <alicejw@amazon.com>
@alicejw1
Copy link
Contributor Author

alicejw1 commented May 16, 2022

Hi @VachaShah , could you please review this change to verify its accuracy per Issue 517?
Thanks,
Alice

@alicejw1 alicejw1 requested a review from VachaShah May 16, 2022 17:29
for clarity about setting deprecated in 1.x and removed in 2.0.
7dbe65f 
Signed-off-by: alicejw <alicejw@amazon.com>
VachaShah
VachaShah reviewed May 17, 2022
View reviewed changes
@alicejw1 alicejw1 requested a review from saratvemulapalli May 17, 2022 21:12
@alicejw1
Copy link
Contributor Author

alicejw1 commented May 17, 2022

Hi @saratvemulapalli , could you please review the changes I've proposed to address the 517 issue?
Please let me know if it is accurate, or if there is anything missed that we should include to clarify for customers how they will be affected by the deprecated (1.0) and removed (2.0) setting.

The reference bugs linked to issue 517 seemed to indicate this:
The setting was removed from OpenSearch 2.0.
We will not support this anymore for clients working with OpenSearch clusters 2.0 and up.

Could you please let me know if this is accurate? Thanks

for requester's PR review and updates for accuracy
997bd48 
Signed-off-by: alicejw <alicejw@amazon.com>
@alicejw1 alicejw1 requested a review from VachaShah May 18, 2022 00:32
for small fix to move note syntax into commented-out section
bd5e27a 
Signed-off-by: alicejw <alicejw@amazon.com>
@saratvemulapalli
Copy link
Member

saratvemulapalli commented May 18, 2022

Hi @saratvemulapalli , could you please review the changes I've proposed to address the 517 issue? Please let me know if it is accurate, or if there is anything missed that we should include to clarify for customers how they will be affected by the deprecated (1.0) and removed (2.0) setting.

The reference bugs linked to issue 517 seemed to indicate this: The setting was removed from OpenSearch 2.0. We will not support this anymore for clients working with OpenSearch clusters 2.0 and up.

Could you please let me know if this is accurate? Thanks

Looks good to me.
Thanks for taking care of this @alicejw-aws !

VachaShah
VachaShah approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@VachaShah VachaShah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @alicejw-aws!

@alicejw1 alicejw1 removed the request for review from elfisher May 18, 2022 17:53
natebower
natebower reviewed May 23, 2022
View reviewed changes
Copy link
Contributor

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my suggested changes and let me know if you have any questions. Thanks!

for editor's feedback updates
90a5a61 
Signed-off-by: alicejw <alicejw@amazon.com>
@alicejw1 alicejw1 merged commit eeb8414 into opensearch-project:main May 23, 2022
@Naarcha-AWS Naarcha-AWS mentioned this pull request Jun 30, 2022
Closed
1 task
JeffHuss pushed a commit that referenced this pull request Jul 1, 2022
Reverted the changes from PR #558
a73879d 
Signed-off-by: jeffhuss <jeffhuss@amazon.com>
JeffHuss pushed a commit that referenced this pull request Jul 1, 2022
Reverted the changes from PR #558 (#747)
ff4a818 
Signed-off-by: jeffhuss <jeffhuss@amazon.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 1, 2022
@github-actions
Reverted the changes from PR #558 (#747)
791c143 
Signed-off-by: jeffhuss <jeffhuss@amazon.com>
(cherry picked from commit ff4a818)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 1, 2022
@github-actions
Reverted the changes from PR #558 (#747)
acded48 
Signed-off-by: jeffhuss <jeffhuss@amazon.com>
(cherry picked from commit ff4a818)
Naarcha-AWS pushed a commit that referenced this pull request Jul 1, 2022
@opensearch-trigger-bot
Reverted the changes from PR #558 (#747) (#750)
e20f441 
Signed-off-by: jeffhuss <jeffhuss@amazon.com>
(cherry picked from commit ff4a818)

Co-authored-by: Jeff Huss <jeffhuss@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

5 more reviewers

@tlfeng tlfeng tlfeng left review comments

@natebower natebower natebower left review comments

@VachaShah VachaShah VachaShah approved these changes

@saratvemulapalli saratvemulapalli saratvemulapalli approved these changes

@Naarcha-AWS Naarcha-AWS Naarcha-AWS approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@alicejw1 alicejw1

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Remove] Override main response feature for clients

6 participants

@alicejw1 @saratvemulapalli @VachaShah @tlfeng @Naarcha-AWS @natebower