Add new settings for SAML and OIDC that allow for cookie splitting#3807
Add new settings for SAML and OIDC that allow for cookie splitting#3807
Conversation
Signed-off-by: cwillum <cwmmoore@amazon.com>
Signed-off-by: cwillum <cwmmoore@amazon.com>
Signed-off-by: cwillum <cwmmoore@amazon.com>
Signed-off-by: cwillum <cwmmoore@amazon.com>
|
@opensearch-project/security Hi team. Could you have a look at these brief additions to SAML and OIDC configuration sections? They include description of the new setting that allows you to split cookies for session management (merged in #1352.) Can you also confirm that the |
DarshitChanpura
left a comment
There was a problem hiding this comment.
@cwillum The changes look good to me!
These changes look good to me. The description is accurate.
This description looks good to me. |
|
@DarshitChanpura Big thanks for the review. |
kolchfa-aws
left a comment
There was a problem hiding this comment.
LGTM. Left some suggestions for clarification.
Signed-off-by: cwillum <cwmmoore@amazon.com>
| opensearch_security.openid.extra_storage.additional_cookies: 3 | ||
| ``` | ||
|
|
||
| Note that reducing the number of additional cookies can cause some of the cookies in use before the change to stop working. We recommend establishing a fixed number of additional cookies and not changing the configuration after that. |
There was a problem hiding this comment.
| Note that reducing the number of additional cookies can cause some of the cookies in use before the change to stop working. We recommend establishing a fixed number of additional cookies and not changing the configuration after that. | |
| Note that reducing the number of additional cookies can cause some of the cookies that were in use before the change to stop working. We recommend establishing a fixed number of additional cookies and not changing the configuration after that. |
…3807) * fix#3691 cookie spitting Signed-off-by: cwillum <cwmmoore@amazon.com> * fix#3691 cookie spitting Signed-off-by: cwillum <cwmmoore@amazon.com> * fix#3691 cookie spitting Signed-off-by: cwillum <cwmmoore@amazon.com> * fix#3691 cookie spitting Signed-off-by: cwillum <cwmmoore@amazon.com> * fix#3691 cookie splitting Signed-off-by: cwillum <cwmmoore@amazon.com> * fix#3691 cookie spitting Signed-off-by: cwillum <cwmmoore@amazon.com> --------- Signed-off-by: cwillum <cwmmoore@amazon.com> (cherry picked from commit 773559a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…3807) * fix#3691 cookie spitting Signed-off-by: cwillum <cwmmoore@amazon.com> * fix#3691 cookie spitting Signed-off-by: cwillum <cwmmoore@amazon.com> * fix#3691 cookie spitting Signed-off-by: cwillum <cwmmoore@amazon.com> * fix#3691 cookie spitting Signed-off-by: cwillum <cwmmoore@amazon.com> * fix#3691 cookie splitting Signed-off-by: cwillum <cwmmoore@amazon.com> * fix#3691 cookie spitting Signed-off-by: cwillum <cwmmoore@amazon.com> --------- Signed-off-by: cwillum <cwmmoore@amazon.com> (cherry picked from commit 773559a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…3807) (#3887) * fix#3691 cookie spitting * fix#3691 cookie spitting * fix#3691 cookie spitting * fix#3691 cookie spitting * fix#3691 cookie splitting * fix#3691 cookie spitting --------- (cherry picked from commit 773559a) Signed-off-by: cwillum <cwmmoore@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…3807) (#3888) * fix#3691 cookie spitting * fix#3691 cookie spitting * fix#3691 cookie spitting * fix#3691 cookie spitting * fix#3691 cookie splitting * fix#3691 cookie spitting --------- (cherry picked from commit 773559a) Signed-off-by: cwillum <cwmmoore@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.1 2.1
# Navigate to the new working tree
pushd ../.worktrees/backport-2.1
# Create a new branch
git switch --create backport/backport-3807-to-2.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 773559ac755d6df14e0d49d93bceae71f644b84e
# Push it to GitHub
git push --set-upstream origin backport/backport-3807-to-2.1
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.1Then, create a pull request where the |
…3807) * fix#3691 cookie spitting Signed-off-by: cwillum <cwmmoore@amazon.com> * fix#3691 cookie spitting Signed-off-by: cwillum <cwmmoore@amazon.com> * fix#3691 cookie spitting Signed-off-by: cwillum <cwmmoore@amazon.com> * fix#3691 cookie spitting Signed-off-by: cwillum <cwmmoore@amazon.com> * fix#3691 cookie splitting Signed-off-by: cwillum <cwmmoore@amazon.com> * fix#3691 cookie spitting Signed-off-by: cwillum <cwmmoore@amazon.com> --------- Signed-off-by: cwillum <cwmmoore@amazon.com> (cherry picked from commit 773559a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…3807) (#3889) * fix#3691 cookie spitting * fix#3691 cookie spitting * fix#3691 cookie spitting * fix#3691 cookie spitting * fix#3691 cookie splitting * fix#3691 cookie spitting --------- (cherry picked from commit 773559a) Signed-off-by: cwillum <cwmmoore@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.1 2.1
# Navigate to the new working tree
pushd ../.worktrees/backport-2.1
# Create a new branch
git switch --create backport/backport-3807-to-2.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 773559ac755d6df14e0d49d93bceae71f644b84e
# Push it to GitHub
git push --set-upstream origin backport/backport-3807-to-2.1
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.1Then, create a pull request where the |
…3807) * fix#3691 cookie spitting Signed-off-by: cwillum <cwmmoore@amazon.com> * fix#3691 cookie spitting Signed-off-by: cwillum <cwmmoore@amazon.com> * fix#3691 cookie spitting Signed-off-by: cwillum <cwmmoore@amazon.com> * fix#3691 cookie spitting Signed-off-by: cwillum <cwmmoore@amazon.com> * fix#3691 cookie splitting Signed-off-by: cwillum <cwmmoore@amazon.com> * fix#3691 cookie spitting Signed-off-by: cwillum <cwmmoore@amazon.com> --------- Signed-off-by: cwillum <cwmmoore@amazon.com>
|
Description
Two new settings are added to
opensearch_dashboards.ymlthat allow for splitting session payloads into multiple cookies to help prevent from hitting cookie limits.Issues Resolved
Added documentation for these settings in SAML and OIDC backend configuration.
Fixes #3691
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.