Skip to content

Update put-mapping.md: add "dynamic"#3384

Merged
ariamarble merged 2 commits intoopensearch-project:mainfrom
varfrog:patch-1
Mar 16, 2023
Merged

Update put-mapping.md: add "dynamic"#3384
ariamarble merged 2 commits intoopensearch-project:mainfrom
varfrog:patch-1

Conversation

@varfrog
Copy link
Contributor

@varfrog varfrog commented Mar 10, 2023

Update put-mapping.md: add an example for "dynamic": "strict" in index JSON

Description

Adds documentation for index mapping property "dynamic", which is a sibling property of "properties".

Issues Resolved

Closes [https://github.com//issues/3383]

Checklist

  • [ x ] By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@varfrog varfrog requested a review from a team as a code owner March 10, 2023 17:58
@Naarcha-AWS Naarcha-AWS added backport 2.0 PR: Backport label for v2.0.x backport 2.1 PR: Backport label for 2.1 backport 2.2 PR: Backport label for 2.2 backport 2.3 PR: Backport label for 2.3 backport 2.4 PR: Backport label for 2.4 backport 2.5 PR: Backport label for 2.5 backport 2.6 PR: Backport label for 2.6 labels Mar 10, 2023
@ariamarble ariamarble self-assigned this Mar 10, 2023
ariamarble
ariamarble reviewed Mar 16, 2023
View reviewed changes
ariamarble
ariamarble reviewed Mar 16, 2023
View reviewed changes
@carolxob carolxob self-requested a review March 16, 2023 16:40
carolxob
carolxob approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@carolxob carolxob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ariamarble ariamarble merged commit eead5ec into opensearch-project:main Mar 16, 2023
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Mar 16, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 16, 2023
@github-actions @ariamarble
Update put-mapping.md: add "dynamic" (#3384)
4f0e1c4 
* Update put-mapping.md: add an example for "dynamic": "strict" in index mapping JSON

* Apply suggestions from code review

---------

Co-authored-by: Aria Marble <111301581+ariamarble@users.noreply.github.com>
(cherry picked from commit eead5ec)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Mar 16, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 16, 2023
@github-actions @ariamarble
Update put-mapping.md: add "dynamic" (#3384)
5e4a7d0 
* Update put-mapping.md: add an example for "dynamic": "strict" in index mapping JSON

* Apply suggestions from code review

---------

Co-authored-by: Aria Marble <111301581+ariamarble@users.noreply.github.com>
(cherry picked from commit eead5ec)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Mar 16, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 16, 2023
@github-actions @ariamarble
Update put-mapping.md: add "dynamic" (#3384)
ba1b6ac 
* Update put-mapping.md: add an example for "dynamic": "strict" in index mapping JSON

* Apply suggestions from code review

---------

Co-authored-by: Aria Marble <111301581+ariamarble@users.noreply.github.com>
(cherry picked from commit eead5ec)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Mar 16, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 16, 2023
@github-actions @ariamarble
Update put-mapping.md: add "dynamic" (#3384)
f53f3b1 
* Update put-mapping.md: add an example for "dynamic": "strict" in index mapping JSON

* Apply suggestions from code review

---------

Co-authored-by: Aria Marble <111301581+ariamarble@users.noreply.github.com>
(cherry picked from commit eead5ec)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Mar 16, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 16, 2023
@github-actions @ariamarble
Update put-mapping.md: add "dynamic" (#3384)
628bb1c 
* Update put-mapping.md: add an example for "dynamic": "strict" in index mapping JSON

* Apply suggestions from code review

---------

Co-authored-by: Aria Marble <111301581+ariamarble@users.noreply.github.com>
(cherry picked from commit eead5ec)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Mar 16, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 16, 2023
@github-actions @ariamarble
Update put-mapping.md: add "dynamic" (#3384)
b0d09d7 
* Update put-mapping.md: add an example for "dynamic": "strict" in index mapping JSON

* Apply suggestions from code review

---------

Co-authored-by: Aria Marble <111301581+ariamarble@users.noreply.github.com>
(cherry picked from commit eead5ec)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Mar 16, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 16, 2023
@github-actions @ariamarble
Update put-mapping.md: add "dynamic" (#3384)
f121443 
* Update put-mapping.md: add an example for "dynamic": "strict" in index mapping JSON

* Apply suggestions from code review

---------

Co-authored-by: Aria Marble <111301581+ariamarble@users.noreply.github.com>
(cherry picked from commit eead5ec)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ariamarble added a commit that referenced this pull request Mar 16, 2023
@opensearch-trigger-bot @github-actions @ariamarble
Update put-mapping.md: add "dynamic" (#3384) (#3489)
bfcd9f3 
* Update put-mapping.md: add an example for "dynamic": "strict" in index mapping JSON

* Apply suggestions from code review

---------


(cherry picked from commit eead5ec)

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Aria Marble <111301581+ariamarble@users.noreply.github.com>
ariamarble added a commit that referenced this pull request Mar 16, 2023
@opensearch-trigger-bot @github-actions @ariamarble
Update put-mapping.md: add "dynamic" (#3384) (#3488)
7d14586 
* Update put-mapping.md: add an example for "dynamic": "strict" in index mapping JSON

* Apply suggestions from code review

---------


(cherry picked from commit eead5ec)

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Aria Marble <111301581+ariamarble@users.noreply.github.com>
ariamarble added a commit that referenced this pull request Mar 16, 2023
@opensearch-trigger-bot @github-actions @ariamarble
Update put-mapping.md: add "dynamic" (#3384) (#3487)
c402efc 
* Update put-mapping.md: add an example for "dynamic": "strict" in index mapping JSON

* Apply suggestions from code review

---------


(cherry picked from commit eead5ec)

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Aria Marble <111301581+ariamarble@users.noreply.github.com>
ariamarble added a commit that referenced this pull request Mar 16, 2023
@opensearch-trigger-bot @github-actions @ariamarble
Update put-mapping.md: add "dynamic" (#3384) (#3486)
fd32acc 
* Update put-mapping.md: add an example for "dynamic": "strict" in index mapping JSON

* Apply suggestions from code review

---------


(cherry picked from commit eead5ec)

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Aria Marble <111301581+ariamarble@users.noreply.github.com>
ariamarble added a commit that referenced this pull request Mar 16, 2023
@opensearch-trigger-bot @github-actions @ariamarble
Update put-mapping.md: add "dynamic" (#3384) (#3485)
bb0394a 
* Update put-mapping.md: add an example for "dynamic": "strict" in index mapping JSON

* Apply suggestions from code review

---------


(cherry picked from commit eead5ec)

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Aria Marble <111301581+ariamarble@users.noreply.github.com>
ariamarble added a commit that referenced this pull request Mar 16, 2023
@opensearch-trigger-bot @github-actions @ariamarble
Update put-mapping.md: add "dynamic" (#3384) (#3484)
dcb1df8 
* Update put-mapping.md: add an example for "dynamic": "strict" in index mapping JSON

* Apply suggestions from code review

---------


(cherry picked from commit eead5ec)

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Aria Marble <111301581+ariamarble@users.noreply.github.com>
ariamarble added a commit that referenced this pull request Mar 16, 2023
@opensearch-trigger-bot @github-actions @ariamarble
Update put-mapping.md: add "dynamic" (#3384) (#3483)
5559c8b 
* Update put-mapping.md: add an example for "dynamic": "strict" in index mapping JSON

* Apply suggestions from code review

---------


(cherry picked from commit eead5ec)

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Aria Marble <111301581+ariamarble@users.noreply.github.com>
@Naarcha-AWS Naarcha-AWS mentioned this pull request Mar 16, 2023
Closed
3 tasks
vagimeli pushed a commit that referenced this pull request May 4, 2023
@varfrog @ariamarble @vagimeli
Update put-mapping.md: add "dynamic" (#3384)
118c02c 
* Update put-mapping.md: add an example for "dynamic": "strict" in index mapping JSON

* Apply suggestions from code review

---------

Co-authored-by: Aria Marble <111301581+ariamarble@users.noreply.github.com>
vagimeli added a commit that referenced this pull request May 4, 2023
@vagimeli
Revert "Update put-mapping.md: add "dynamic" (#3384)"
748262f 
This reverts commit 118c02c.
harshavamsi pushed a commit to harshavamsi/documentation-website that referenced this pull request Oct 31, 2023
@varfrog @ariamarble @harshavamsi
Update put-mapping.md: add "dynamic" (opensearch-project#3384)
54bdb8f 
* Update put-mapping.md: add an example for "dynamic": "strict" in index mapping JSON

* Apply suggestions from code review

---------

Co-authored-by: Aria Marble <111301581+ariamarble@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Naarcha-AWS Naarcha-AWS Awaiting requested review from Naarcha-AWS

2 more reviewers

@ariamarble ariamarble ariamarble approved these changes

@carolxob carolxob carolxob approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ariamarble ariamarble

Labels

backport 2.0 PR: Backport label for v2.0.x backport 2.1 PR: Backport label for 2.1 backport 2.2 PR: Backport label for 2.2 backport 2.3 PR: Backport label for 2.3 backport 2.4 PR: Backport label for 2.4 backport 2.5 PR: Backport label for 2.5 backport 2.6 PR: Backport label for 2.6

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@varfrog @ariamarble @carolxob @Naarcha-AWS