Skip to content

Update link checker#3240

Closed
kolchfa-aws wants to merge 2 commits intomainfrom
link-checker-update
Closed

Update link checker#3240
kolchfa-aws wants to merge 2 commits intomainfrom
link-checker-update

Conversation

@kolchfa-aws
Copy link
Collaborator

Add red warning/error color and change workflow from raising an exception to system exit.

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
@kolchfa-aws kolchfa-aws requested a review from a team as a code owner March 6, 2023 18:45
@kolchfa-aws kolchfa-aws self-assigned this Mar 6, 2023
Copy link
Contributor

@vagimeli vagimeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
@Naarcha-AWS
Copy link
Contributor

Waiting on another review from @AMoo-Miki to verify that the linkchecker still works after a couple of fixes.

@dblock
Copy link
Member

dblock commented Apr 3, 2023

Superseded with #3584.

@kolchfa-aws
Copy link
Collaborator Author

Closing because everything will be implemented in #3584

@kolchfa-aws kolchfa-aws closed this Apr 3, 2023
@kolchfa-aws kolchfa-aws deleted the link-checker-update branch March 28, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants